Skip to content

Fix test assertions for copilot-sdk engine registration#15695

Merged
pelikhan merged 2 commits intocopilot/add-copilot-sdk-enginefrom
copilot/fix-tests-please-work
Feb 14, 2026
Merged

Fix test assertions for copilot-sdk engine registration#15695
pelikhan merged 2 commits intocopilot/add-copilot-sdk-enginefrom
copilot/fix-tests-please-work

Conversation

Copy link
Contributor

Copilot AI commented Feb 14, 2026

Both copilot and copilot-sdk engines use COPILOT_GITHUB_TOKEN. Test assertions that validate error messages containing engine names were hard-coded to expect "GitHub Copilot CLI", causing failures when "GitHub Copilot SDK" appears instead (determined by engine registry iteration order).

Changes

  • pkg/workflow/imported_steps_validation_test.go: Use OR assertions to accept either "GitHub Copilot CLI" or "GitHub Copilot SDK" in agentic secret validation errors
  • cmd/gh-aw/main_entry_test.go: Add copilot-sdk test case and update invalid engine error message expectations to include 'copilot-sdk' in valid engines list
// Before: Hard-coded expectation
assert.Contains(t, err.Error(), "GitHub Copilot CLI")

// After: Flexible assertion
hasCopilotCLI := strings.Contains(errMsg, "GitHub Copilot CLI")
hasCopilotSDK := strings.Contains(errMsg, "GitHub Copilot SDK")
assert.True(t, hasCopilotCLI || hasCopilotSDK)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name 64/pkg/tool/linu-lang=go1.25 (http block)
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh repo view owner/repo (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha runs/20260214-151324-14390/test-225405765/.github/workflows -buildtags ache/node/24.13.0/x64/bin/node l -ifaceassert -nilfunc /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet t-32�� sistency_GoAndJavaScript3642935226/001/test-simple-frontmatter.md -buildtags /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/link -errorsas -ifaceassert -nilfunc /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linurev-parse (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha -json GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linutest@example.com (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha runs/20260214-152127-39945/test-3382952088/.github/workflows git /home/REDACTED/.dotnet/tools/git l go /usr/bin/git git --ve�� ings.cjs forks.js ache/node/24.13.0/x64/bin/node --show-toplevel git modules/@npmcli/--show-toplevel ache/node/24.13.0/x64/bin/node (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha 2337231271 2218212/b121/vet.cfg .cfg (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha test-uYzODH/slow.go x_amd64/vet 0/x64/bin/node ve go tions/setup/js/n-v tions/setup/js/node_modules/vitest/dist/workers/forks.js -has�� SameOutput412012263/001/stability-test.md git k/_temp/ghcca-node/node/bin/git tags/v4 go modules/@npmcli/--show-toplevel /opt/hostedtoolcache/node/24.13.0/x64/bin/node (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha .go o x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha -unreachable=false /tmp/go-build3632218212/b052/vet.cfg 0/x64/bin/node (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha -test.paniconexit0 -test.v=true /opt/hostedtoolcache/node/24.13.0/x64/bin/node -test.timeout=10git -test.run=^Test -test.short=true--show-toplevel node /tmp�� image:v1.0.0 x_amd64/vet /usr/bin/git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha 2218212/b418/timeutil.test -trimpath clusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle -p github.com/aymanrev-parse -lang=go1.23 iiEtxJ64HjgrP/g5FpiJ9ENbZatjTay5oJ/BhqTCoRMGewfss9ZXZGY/X4XoDkfiiEtxJ64HjgrP -C runs/20260214-151324-14390/test-2337231271 config 2218212/b418/_pkg_.a remote.origin.urgit -nolocalimports -importcfg git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha WorkflowFiles_TransitiveImports2602502266/001 origin /usr/bin/git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -c=4 -nolocalimports -importcfg /tmp/go-build3632218212/b402/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/pkg/repoutil/repoutil.go /home/REDACTED/work/gh-aw/gh-aw/pkg/repoutil/repoutil_test.go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha g/parser/import_error_test.go g/parser/import_topological_test.go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha ring2795165796/001/test1.md /tmp/go-build3632218212/b010/vet.cfg (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha ithub/workflows/brave.md GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha /opt/hostedtoolcache/go/1.25.0/xfeature"; curl evil.com git /home/REDACTED/.local/bin/git --show-toplevel go 0/x64/lib/node_m--show-toplevel git inva�� ings.cjs forks.js /home/REDACTED/.config/composer/vendor/bin/git --show-toplevel go /usr/bin/git git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha g/cli /tmp/go-build3632218212/b039/vet.cfg x_amd64/link (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha -json GO111MODULE 0/x64/bin/node GOINSECURE GOMOD GOMODCACHE 0/x64/bin/node t-11�� sistency_WithImports444346465/001/main.md GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha /tmp/go-handler-test-uYzODH/slow.go 64/pkg/tool/linux_amd64/vet /home/REDACTED/work/_temp/ghcca-node/node/bin/git --show-toplevel go (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 GO111MODULE 0/x64/bin/node GOINSECURE GOMOD GOMODCACHE go t-ha�� ithub/workflows/artifacts-summary.md GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 Update"; echo hacked ache/node/24.13.0/x64/bin/node --show-toplevel 64/pkg/tool/linuapi /usr/bin/git ache/node/24.13.--jq test�� ache/go/1.25.0/xfeaturewhoami /usr/bin/git 64/pkg/tool/linux_amd64/vet -v go /usr/bin/git 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 Update malicious command ndor/bin/git etup-node/git/regit go /usr/bin/git node serv�� st-AohsWl/test-config.json /usr/bin/git k/gh-aw/gh-aw/actions/node_modules/.bin/go --get-regexp ^remote\..*\.gh-init /usr/bin/git /opt/hostedtoolcache/node/24.13.0/x64/bin/node (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 Update malicious command ache/node/24.13.0/x64/bin/node --show-toplevel go /usr/bin/git ache/node/24.13.test@example.com st-A�� ache/go/1.25.0/xfeature | cat /eremote.origin.url /usr/bin/git k/gh-aw/gh-aw/node_modules/.bin/go --get-regexp ^remote\..*\.gh-rev-parse /usr/bin/git /opt/hostedtoolcache/node/24.13.0/x64/bin/node (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 --conditions ache/node/24.13.0/x64/bin/node --experimental-igit --require /home/REDACTED/wor--show-toplevel ache/node/24.13.0/x64/bin/node test�� brave.md git 64/pkg/tool/linux_amd64/vet get-url origin /usr/bin/git 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 0/x64/bin/node GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 --conditions ache/node/24.13.0/x64/bin/node --experimental-igit --require /home/REDACTED/wor--show-toplevel ache/node/24.13.0/x64/bin/node test�� ache/go/1.25.0/xfeaturewhoami /usr/bin/git 64/pkg/tool/linux_amd64/vet --get-regexp ^remote\..*\.gh-rev-parse /usr/bin/git 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 Update"; echo hacked ache/node/24.13.0/x64/bin/node --show-toplevel 64/pkg/tool/linurev-parse /usr/bin/infocmp--show-toplevel ache/node/24.13.0/x64/bin/node test�� ache/go/1.25.0/xfeature$(whoami) infocmp 64/pkg/tool/linux_amd64/vet xterm-color go /usr/bin/git 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 git 9c2e3f4ed325028cfbbc2ac1beedc10710de06d139bb4644-d --show-toplevel 64/pkg/tool/linurev-parse run-script/lib/n--show-toplevel ache/node/24.13.0/x64/bin/node /hom�� po.git git 64/pkg/tool/linux_amd64/vet mport-meta-resolgit remote.origin.urrev-parse k/gh-aw/gh-aw/ac--show-toplevel 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 (http block)
  • https://api.github.com/repos/github/gh-aw/contents/.github%2Fworkflows%2Faudit-workflows.md
    • Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnings.cjs /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/dist/workers/forks.js GO111MODULE .cfg git rev-�� 40\} tch /opt/hostedtoolcache/go/1.25.0/x64/bin/node -json GO111MODULE ache/go/1.25.0/xnode node (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha 2892140822/.github/workflows .cfg 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha 2888c116b4dd41c7GOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD ode-gyp-bin/node-json ache/go/1.25.0/xGO111MODULE env 2164926/b389/_pkGOINSECURE GO111MODULE 64/bin/go GOINSECURE b/gh-aw/pkg/parsrev-parse GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha om/user/repo.gitremote.origin.url conntrack ache/node/24.13.0/x64/bin/node INVALID,NEW -j DROP ache/node/24.13.rev-parse ndle�� git rev-parse --abbrev-ref HEAD git 0/x64/bin/node user.name Test User /usr/bin/git 0/x64/bin/node (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion mport-meta-resolgit go k/gh-aw/gh-aw/ac--show-toplevel 0/x64/bin/node /hom�� test-uYzODH/slow.go x_amd64/vet k/gh-aw/node_modules/.bin/git ve go tions/setup/js/n--show-toplevel tions/setup/js/node_modules/vitest/dist/workers/forks.js (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo (http block)
    • Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOINSECURE GOMOD GOMODCACHE ortcfg env b136a0101c461533GOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/xGO111MODULE (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name GOSUMDB GOWORK 64/bin/go GOINSECURE GOMOD GOMODCACHE ortcfg env g/repoutil/repouGOINSECURE g/repoutil/repouGOMOD 64/bin/go GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/xGO111MODULE (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name ; rm -rf / git tions/setup/js/node_modules/.bin/git --show-toplevel go /usr/bin/git Uh2YAth/Q5wuAAQS7mtu77SzHUyA rev-�� abbrev-ref HEAD git 0/x64/bin/node GOMODCACHE go /usr/bin/git git (http block)
  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login me)" 64/pkg/tool/linux_amd64/vet /usr/bin/git .go .go 64/pkg/tool/linu--noprofile git rev-�� --show-toplevel 64/pkg/tool/linuremote.origin.url ache/node/24.13.0/x64/bin/node get --local ache/go/1.25.0/x--noprofile git (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login --show-toplevel 64/pkg/tool/linuconfig /usr/bin/git get --local ache/go/1.25.0/x-v git rev-�� --show-toplevel ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet /usr/bin/git 1324-14390/test-git 2218212/b145/vetls-files .cfg git (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Reference: https://github.com/github/gh-aw/actions/runs/22019219179/job/63625706784#step:10:1

Fix tests


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Updated TestValidateImportedStepsNoAgenticSecrets tests to accept both "GitHub Copilot CLI" and "GitHub Copilot SDK"
- Added test case for valid copilot-sdk engine in TestValidateEngine
- Updated error message expectation to include copilot-sdk in list of valid engines

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing tests in the project Fix test assertions for copilot-sdk engine registration Feb 14, 2026
Copilot AI requested a review from pelikhan February 14, 2026 15:23
@pelikhan pelikhan marked this pull request as ready for review February 14, 2026 15:38
Copilot AI review requested due to automatic review settings February 14, 2026 15:38
@pelikhan pelikhan merged commit 4a121f8 into copilot/add-copilot-sdk-engine Feb 14, 2026
2 checks passed
@pelikhan pelikhan deleted the copilot/fix-tests-please-work branch February 14, 2026 15:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes flaky test failures caused by non-deterministic Go map iteration order when both copilot and copilot-sdk engines are registered. Since both engines use the same COPILOT_GITHUB_TOKEN secret, error messages can contain either "GitHub Copilot CLI" or "GitHub Copilot SDK" depending on which engine is encountered first during map iteration.

Changes:

  • Updated test assertions to accept either "GitHub Copilot CLI" or "GitHub Copilot SDK" in agentic secret validation errors using OR logic
  • Added test case for copilot-sdk engine validation
  • Updated expected error message in validateEngine tests to include 'copilot-sdk' in the valid engines list

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/workflow/imported_steps_validation_test.go Updated assertions to use OR conditions checking for either "GitHub Copilot CLI" or "GitHub Copilot SDK" in error messages, fixing non-deterministic test failures
cmd/gh-aw/main_entry_test.go Added test case for valid copilot-sdk engine and updated expected error message to include 'copilot-sdk' in the sorted list of valid engines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pelikhan added a commit that referenced this pull request Feb 14, 2026
…rt (#15642)

* Initial plan

* Add copilot-sdk engine implementation

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Add tests for copilot-sdk engine and update existing tests

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Fix linter error in copilot_sdk_engine_test.go

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Add copilot-sdk to schema and create example workflow

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Remove stdin support from copilot-client, only use GH_AW_COPILOT_CONFIG env var

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Move copilot-sdk example to dev.md and delete example-copilot-sdk.md

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Mark copilot-sdk engine as experimental

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Update dev.md to use copilot-sdk engine with daily status report workflow

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Update copilot_sdk_engine.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Create smoke-copilot-sdk.md workflow and remove dev.md

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Restore dev.md as daily status report with copilot-sdk engine

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Fix test assertions for copilot-sdk engine registration (#15695)

* Change SupportsLLMGateway to return port number instead of boolean

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Simplify BaseEngine SupportsLLMGateway to always return -1

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Recompile all workflows after merging main

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Change copilot-sdk CLI port from 3312 to 10002 and fail on config marshal error

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Remove invalid --api-proxy-port flag from AWF commands

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants