Document agent runtime selection and troubleshooting - #51427
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a9759f72-8612-45b7-9a94-e1f968e96ef4
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a9759f72-8612-45b7-9a94-e1f968e96ef4
There was a problem hiding this comment.
Pull request overview
Adds a reference for selecting, configuring, and troubleshooting agent runtimes.
Changes:
- Documents Docker, gVisor, Docker sbx, and ARC DinD.
- Clarifies runtime fields, prerequisites, tradeoffs, and troubleshooting.
- Adds the reference page to navigation.
Show a summary per file
| File | Description |
|---|---|
docs/src/content/docs/reference/agent-runtimes.md |
Adds the runtime reference. |
docs/astro.config.mjs |
Adds navigation for the new page. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Balanced
|
|
||
| **Compilation rejects `sudo` or `apt-get install`:** Move system packages into the runner image or DinD image. ARC DinD workflows are validated as rootless and must not bootstrap host packages during the job. | ||
|
|
||
| **`Docker daemon is not accessible` from the MCP gateway:** If a Unix socket is mounted at a nonstandard path, set `GH_AW_DOCKER_SOCK_PATH` and `GH_AW_DOCKER_SOCK_GID` in the runner pod. Both values are required. See [Docker socket override for split-daemon topologies](/gh-aw/reference/self-hosted-runners/#docker-socket-override-for-split-daemon-topologies). |
|
|
||
| **`KVM kernel module is not loaded` or `/dev/kvm is missing`:** The runner does not provide hardware virtualization. Enable nested virtualization and pass `/dev/kvm` through to the runner, or select gVisor or Docker. Frontmatter cannot add KVM capability. With `runtime-install: false`, this generated check is skipped, but sbx execution still fails if KVM is unavailable. | ||
|
|
||
| **Permission denied for `/dev/kvm`:** Confirm the runner can execute passwordless `sudo` and that its security policy permits the generated `chmod 666 /dev/kvm`. If that policy is unacceptable, do not use Docker sbx. |
Visual Regression Check - Unable to CompleteAttempted to load the docs server at (host.docker.internal/redacted) via playwright-cli to capture mobile/tablet/desktop screenshots, but every navigation attempt returned HTTP 403 Forbidden (Page Title: ERROR: The requested URL could not be retrieved). This occurred consistently across multiple retries, indicating the sandboxed browser could not reach the docs server (likely a network/proxy restriction rather than an app issue). No screenshots or accessibility snapshots could be captured.
No visual comparison or accessibility review was possible this run. Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "host.docker.internal"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
|
@copilot address review feedback |
|
@copilot Quick triage nudge for this PR. Please refresh the branch if GitHub can update it cleanly, address the latest review feedback, and run the Open items (newest first):
Run: https://github.com/github/gh-aw/actions/runs/31270434674
|
| - [report.md](report.md) for reporting output structure and recurring report lifecycle | ||
| - [release-workflow.md](release-workflow.md) for release workflows that build, test, publish a GitHub release, and generate release highlights | ||
| - [linter-workflows.md](linter-workflows.md) for mining, refining, or applying custom linter rules | ||
| - [Agent Runtime Selection](../../docs/src/content/docs/reference/agent-runtimes.md) when choosing or debugging Docker, gVisor, Docker sbx, ARC DinD, self-hosted runners, or `sandbox.agent.runtime-install` |
There was a problem hiding this comment.
@copilot create a dedicated instructions file, do not link to "human docs"
There was a problem hiding this comment.
Addressed in 1e46777: added .github/aw/agent-runtime-instructions.md and updated the workflow authoring prompts to reference that dedicated agent instruction file instead of the published docs page.
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Addressed in |
|
@copilot document DOCKER_PAT requirement for docker_sbx |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Ran
Addressed in |
Summary
runtime-install, runner prerequisites, isolation tradeoffs, and incompatibilitiesruntime-installValidation
node --check docs/astro.config.mjsgit diff --checkThe full Astro build could not start because the configured npm feed returned 404 for
vite@8.1.0.