Enable throttler in move-tables mode#1713
Merged
zacharysierakowski merged 1 commit intoJun 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables throttling during the main write/apply loop when running gh-ost in move-tables mode, aligning move-tables execution with the existing throttler behavior used in standard migrations.
Changes:
- Remove the move-tables-mode guard that previously disabled
throttler.throttle(nil)in theexecuteWriteFuncs()loop. - Ensure the write/apply loop is always subject to throttling decisions (HTTP throttling, control-replica lag, max-load/critical-load, flag-file/user throttle).
Show a summary per file
| File | Description |
|---|---|
| go/logic/migrator.go | Enables throttling in move-tables mode by always calling the throttler inside the primary write/apply loop. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| // https://github.com/github/database-infrastructure/issues/8212 | ||
| mgtr.throttler.throttle(nil) | ||
| } | ||
| mgtr.throttler.throttle(nil) |
zacharysierakowski
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
Related issue (internal): https://github.com/github/database-infrastructure/issues/8212
Related issue (public): #1681
Description
This PR enables throttling in move-tables mode.
The code was conditionally turned off at the beginning of development.
script/cibuildreturns with no formatting errors, build errors or unit test errors.