Skip to content

Improved metrics on composite glyphs, more legible numerals #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kylewaynebenson wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improved metrics on composite glyphs, more legible numerals #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
499fbaf
Improved metrics on composite glyphs, more legible numerals
kylewaynebenson Dec 12, 2025
9698600
Initial plan
Copilot Dec 12, 2025
21fb688
Fix width inconsistency in colon_colon.liga.glyph - set m020 layer wi…
Copilot Dec 12, 2025
fee4f4c
Merge pull request #99 from github/copilot/sub-pr-98
kylewaynebenson Dec 12, 2025
1f119a1
Repairing quote mark misalignment
kylewaynebenson Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Binary file modified fonts/static/otf/MonaSansMono-Black.otf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/otf/MonaSansMono-Bold.otf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/otf/MonaSansMono-ExtraBold.otf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/otf/MonaSansMono-ExtraLight.otf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/otf/MonaSansMono-Light.otf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/otf/MonaSansMono-Medium.otf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/otf/MonaSansMono-Regular.otf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/otf/MonaSansMono-SemiBold.otf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/ttf/MonaSansMono-Black.ttf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/ttf/MonaSansMono-Bold.ttf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/ttf/MonaSansMono-ExtraBold.ttf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/ttf/MonaSansMono-ExtraLight.ttf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/ttf/MonaSansMono-Light.ttf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/ttf/MonaSansMono-Medium.ttf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/ttf/MonaSansMono-Regular.ttf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/static/ttf/MonaSansMono-SemiBold.ttf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/variable/MonaSansMonoVF[wght].ttf
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-Black.woff
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-Black.woff2
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-Bold.woff
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-Bold.woff2
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-ExtraBold.woff
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-ExtraBold.woff2
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-ExtraLight.woff
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-ExtraLight.woff2
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-Light.woff
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-Light.woff2
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-Medium.woff
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-Medium.woff2
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-Regular.woff
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-Regular.woff2
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-SemiBold.woff
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/static/MonaSansMono-SemiBold.woff2
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/variable/MonaSansMonoVF[wght].woff
View file
Open in desktop
Binary file not shown.
Binary file modified fonts/webfonts/variable/MonaSansMonoVF[wght].woff2
View file
Open in desktop
Binary file not shown.
186 changes: 143 additions & 43 deletions sources/MonaSansMono.glyphspackage/fontinfo.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
.appVersion = "3343";
.appVersion = "3508";
.formatVersion = 3;
axes = (
{
Expand Down Expand Up @@ -80,8 +80,6 @@ feature numr;
feature dnom;
feature frac;
feature ordn;
feature pnum;
feature tnum;
feature case;
feature ss01;
feature ss02;
Expand All @@ -90,7 +88,8 @@ feature ss04;
feature ss05;
feature ss06;
feature ss07;
feature ss08;
feature ss09;
feature ss10;
";
tag = aalt;
},
Expand Down Expand Up @@ -285,36 +284,6 @@ tag = ordn;
},
{
automatic = 1;
code = "sub zero.tf by zero;
sub one.tf by one;
sub two.tf by two;
sub three.tf by three;
sub four.tf by four;
sub five.tf by five;
sub six.tf by six;
sub seven.tf by seven;
sub eight.tf by eight;
sub nine.tf by nine;
";
tag = pnum;
},
{
automatic = 1;
code = "sub zero by zero.tf;
sub one by one.tf;
sub two by two.tf;
sub three by three.tf;
sub four by four.tf;
sub five by five.tf;
sub six by six.tf;
sub seven by seven.tf;
sub eight by eight.tf;
sub nine by nine.tf;
";
tag = tnum;
},
{
automatic = 1;
code = "sub exclamdown by exclamdown.case;
sub questiondown by questiondown.case;
sub periodcentered.loclCAT by periodcentered.loclCAT.case;
Expand All @@ -337,11 +306,6 @@ tag = case;
},
{
automatic = 1;
code = "";
tag = liga;
},
{
automatic = 1;
code = "sub Abrevedotbelow by Abrevedotbelow.ss01;
sub Acircumflexdotbelow by Acircumflexdotbelow.ss01;
sub Adieresis by Adieresis.ss01;
Expand Down Expand Up @@ -558,15 +522,151 @@ tag = ss07;
},
{
automatic = 1;
code = "sub zero.tf by zero.tf.ss08;
code = "sub one by one.ss09;
";
labels = (
{
language = dflt;
value = "Tabular zero with straight bar";
value = "One no serif";
}
);
tag = ss08;
tag = ss09;
},
{
automatic = 1;
code = "sub zero by zero.ss10;
";
labels = (
{
language = dflt;
value = "Zero no slash";
}
);
tag = ss10;
},
{
code = "lookup ampersand_ampersand.liga {
ignore sub ampersand ampersand' ampersand;
ignore sub ampersand' ampersand ampersand;
sub SPC ampersand' by ampersand_ampersand.liga;
sub ampersand' ampersand by SPC;
} ampersand_ampersand.liga;

lookup bar_bar.liga {
ignore sub bar bar' bar;
ignore sub bar' bar bar;
ignore sub bracketleft bar' bar;
ignore sub bar' bar bracketright;
sub SPC bar' by bar_bar.liga;
sub bar' bar by SPC;
} bar_bar.liga;

lookup equal_equal.liga {
ignore sub equal equal' equal;
ignore sub parenleft question less equal' equal;
ignore sub parenleft question equal' equal;
ignore sub equal' equal equal;
ignore sub equal' equal greater;
sub SPC equal' by equal_equal.liga;
sub equal' equal by SPC;
} equal_equal.liga;
Comment on lines +548 to +572
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contextual ligature lookups use SPC as an intermediate but never fully remove it, so sequences like ampersand ampersand (and similar pairs) will resolve to SPC <ligature> rather than just the ligature glyph. Each lookup currently first rewrites one of the base glyphs to SPC (e.g. sub ampersand' ampersand by SPC;), then rewrites the other in context of SPC (e.g. sub SPC ampersand' by ampersand_ampersand.liga;), leaving the SPC glyph in the final glyph stream. To fix this, either (a) avoid the helper glyph and use a single contextual substitution of the original pair directly to the .liga glyph, or (b) add an additional substitution step that collapses SPC plus the ligature (or SPC alone) into just the ligature so no SPC remains rendered.

Copilot uses AI. Check for mistakes.

lookup equal_greater.liga {
ignore sub bracketleft equal' greater;
ignore sub equal equal' greater;
ignore sub greater equal' greater;
ignore sub bar equal' greater;
ignore sub parenleft question less equal' greater;
ignore sub parenleft question equal' greater;
ignore sub equal' greater equal;
ignore sub equal' greater greater;
sub SPC greater' by equal_greater.liga;
sub equal' greater by SPC;
} equal_greater.liga;

lookup exclam_equal.liga {
ignore sub exclam exclam' equal;
ignore sub parenleft question exclam' equal;
ignore sub parenleft question less exclam' equal;
ignore sub equal exclam' equal;
ignore sub exclam' equal equal;
sub SPC equal' by exclam_equal.liga;
sub exclam' equal by SPC;
} exclam_equal.liga;

lookup greater_equal.liga {
ignore sub greater greater' equal;
ignore sub greater' equal equal;
ignore sub greater' equal greater;
ignore sub greater' equal less;
sub SPC equal' by greater_equal.liga;
sub greater' equal by SPC;
} greater_equal.liga;

lookup hyphen_greater.liga {
ignore sub bracketleft hyphen' greater;
ignore sub hyphen hyphen' greater;
ignore sub greater hyphen' greater;
ignore sub bar hyphen' greater;
ignore sub hyphen' greater greater;
ignore sub plus hyphen' greater;
sub SPC greater' by hyphen_greater.liga;
sub hyphen' greater by SPC;
} hyphen_greater.liga;

lookup less_equal.liga {
ignore sub less' equal less;
ignore sub less' equal bar;
ignore sub less less' equal;
ignore sub parenleft question less' equal;
ignore sub less' equal equal;
sub SPC equal' by less_equal.liga;
sub less' equal by SPC;
} less_equal.liga;

lookup plus_plus.liga {
ignore sub plus plus' plus;
ignore sub colon plus' plus;
ignore sub plus' plus plus;
ignore sub plus' plus colon;
sub SPC plus' by plus_plus.liga;
sub plus' plus by SPC;
} plus_plus.liga;

lookup hyphen_hyphen.liga {
ignore sub bracketleft hyphen' hyphen greater;
ignore sub parenleft question less exclam hyphen' hyphen;
ignore sub hyphen hyphen' hyphen;
ignore sub less hyphen' hyphen;
ignore sub hyphen' hyphen hyphen;
sub SPC hyphen' by hyphen_hyphen.liga;
sub hyphen' hyphen by SPC;
} hyphen_hyphen.liga;

lookup colon_colon.liga {
ignore sub colon colon' colon;
ignore sub colon' colon colon;
ignore sub colon' colon equal;
sub SPC colon' by colon_colon.liga;
sub colon' colon by SPC;
} colon_colon.liga;";
Comment on lines +642 to +652
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contextual ligature lookups use SPC as an intermediate but never fully remove it, so sequences like ampersand ampersand (and similar pairs) will resolve to SPC <ligature> rather than just the ligature glyph. Each lookup currently first rewrites one of the base glyphs to SPC (e.g. sub ampersand' ampersand by SPC;), then rewrites the other in context of SPC (e.g. sub SPC ampersand' by ampersand_ampersand.liga;), leaving the SPC glyph in the final glyph stream. To fix this, either (a) avoid the helper glyph and use a single contextual substitution of the original pair directly to the .liga glyph, or (b) add an additional substitution step that collapses SPC plus the ligature (or SPC alone) into just the ligature so no SPC remains rendered.

Suggested change
sub SPC hyphen' by hyphen_hyphen.liga;
sub hyphen' hyphen by SPC;
} hyphen_hyphen.liga;
lookup colon_colon.liga {
ignore sub colon colon' colon;
ignore sub colon' colon colon;
ignore sub colon' colon equal;
sub SPC colon' by colon_colon.liga;
sub colon' colon by SPC;
} colon_colon.liga;";
sub hyphen hyphen by hyphen_hyphen.liga;
} hyphen_hyphen.liga;
lookup colon_colon.liga {
ignore sub colon colon' colon;
ignore sub colon' colon colon;
ignore sub colon' colon equal;
sub colon colon by colon_colon.liga;
} colon_colon.liga;";

Copilot uses AI. Check for mistakes.
tag = calt;
},
{
automatic = 1;
code = "lookupflag IgnoreMarks;
sub ampersand ampersand by ampersand_ampersand.liga;
sub bar bar by bar_bar.liga;
sub equal equal by equal_equal.liga;
sub equal greater by equal_greater.liga;
sub exclam equal by exclam_equal.liga;
sub greater equal by greater_equal.liga;
sub hyphen greater by hyphen_greater.liga;
sub less equal by less_equal.liga;
sub plus plus by plus_plus.liga;
";
disabled = 1;
tag = liga;
}
);
fontMaster = (
Expand Down Expand Up @@ -1805,5 +1905,5 @@ value = 1.3;
};
};
versionMajor = 0;
versionMinor = 5;
versionMinor = 41;
}
2 changes: 1 addition & 1 deletion sources/MonaSansMono.glyphspackage/glyphs/B_.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ nodes = (
userData = {
com.schriftgestaltung.Glyphs.glyph.leftMetricsKey = H;
};
width = 619;
width = 618;
}
);
metricLeft = H;
Expand Down
2 changes: 1 addition & 1 deletion sources/MonaSansMono.glyphspackage/glyphs/C_.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ type = Stem;
}
);
};
width = 619;
width = 618;
},
{
anchors = (
Expand Down
2 changes: 1 addition & 1 deletion sources/MonaSansMono.glyphspackage/glyphs/C_acute.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pos = (59,57);
ref = acutecomb;
}
);
width = 619;
width = 618;
},
{
layerId = m020;
Expand Down
2 changes: 1 addition & 1 deletion sources/MonaSansMono.glyphspackage/glyphs/C_caron.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pos = (20,57);
ref = caroncomb;
}
);
width = 619;
width = 618;
},
{
layerId = m020;
Expand Down
2 changes: 1 addition & 1 deletion sources/MonaSansMono.glyphspackage/glyphs/C_cedilla.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pos = (15,0);
ref = cedillacomb;
}
);
width = 619;
width = 618;
},
{
layerId = m020;
Expand Down
2 changes: 1 addition & 1 deletion sources/MonaSansMono.glyphspackage/glyphs/C_circumflex.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pos = (20,57);
ref = circumflexcomb;
}
);
width = 619;
width = 618;
},
{
layerId = m020;
Expand Down
2 changes: 1 addition & 1 deletion sources/MonaSansMono.glyphspackage/glyphs/C_dotaccent.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pos = (19,57);
ref = dotaccentcomb;
}
);
width = 619;
width = 618;
},
{
layerId = m020;
Expand Down
2 changes: 1 addition & 1 deletion sources/MonaSansMono.glyphspackage/glyphs/C_dotaccent.ss01.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pos = (19,57);
ref = dotaccentcomb.ss01;
}
);
width = 619;
width = 618;
},
{
layerId = m020;
Expand Down
3 changes: 1 addition & 2 deletions sources/MonaSansMono.glyphspackage/glyphs/D_.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ type = Stem;
}
);
};
width = 619;
width = 618;
},
{
anchors = (
Expand Down Expand Up @@ -196,6 +196,5 @@ com.schriftgestaltung.Glyphs.glyph.leftMetricsKey = H;
width = 618;
}
);
metricLeft = H;
unicode = 68;
}
2 changes: 1 addition & 1 deletion sources/MonaSansMono.glyphspackage/glyphs/D_caron.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pos = (-5,57);
ref = caroncomb;
}
);
width = 619;
width = 618;
},
{
layerId = m020;
Expand Down
2 changes: 1 addition & 1 deletion sources/MonaSansMono.glyphspackage/glyphs/D_croat.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ shapes = (
ref = Eth;
}
);
width = 619;
width = 618;
},
{
layerId = m020;
Expand Down
6 changes: 3 additions & 3 deletions sources/MonaSansMono.glyphspackage/glyphs/E_.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ pos = (543,0);
},
{
name = top;
pos = (312,729);
pos = (341,729);
},
{
name = topleft;
pos = (51,729);
pos = (71,729);
}
);
layerId = m019;
Expand Down Expand Up @@ -124,7 +124,7 @@ pos = (561,0);
},
{
name = top;
pos = (309,729);
pos = (319,729);
},
{
name = topleft;
Expand Down
4 changes: 2 additions & 2 deletions sources/MonaSansMono.glyphspackage/glyphs/E_acute.glyph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ shapes = (
ref = E;
},
{
pos = (42,57);
pos = (71,57);
ref = acutecomb;
}
);
Expand All @@ -24,7 +24,7 @@ shapes = (
ref = E;
},
{
pos = (48,51);
pos = (58,51);
ref = acutecomb;
}
);
Expand Down
Loading
Loading