Fix Dependabot security findings for spark-template (vuln-mgmt#203091)#175
Open
legomushroom wants to merge 2 commits into
Open
Fix Dependabot security findings for spark-template (vuln-mgmt#203091)#175legomushroom wants to merge 2 commits into
legomushroom wants to merge 2 commits into
Conversation
Pin patched versions via npm `overrides` (existing repo convention) and bump the direct `vite` devDependency; regenerate the lockfile: - esbuild -> 0.28.1 (GHSA-gv7w-rqvm-qjhr / GHSA-g7r4-m6w7-qqqr) - vite -> 7.3.5 (GHSA-fx2h-pf6j-xcff) - js-yaml -> 4.2.0 (GHSA-h67p-54hq-rp68; dev-only) - qs -> 6.15.2 (GHSA-q8mj-m7cp-5q26) Verified: all four resolve to patched versions; `npm run build` passes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates dependencies.
Changes:
- Bump the direct
vitedevDependency to^7.3.5. - Add npm
overridesentries intended to force patched versions ofesbuild,vite,js-yaml, andqs. - Regenerate
package-lock.jsonso the resolved versions reflect the patched releases (e.g.,esbuild@0.28.1,vite@7.3.5,js-yaml@4.2.0,qs@6.15.2).
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates vite and adds override entries meant to force patched dependency resolutions. |
| package-lock.json | Updates the resolved dependency tree to the patched versions and refreshes integrity metadata. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/2 changed files
- Comments generated: 1
Match the file's existing override convention (picomatch, postcss, lodash, minimatch are exact-pinned) for reproducible security remediation: - esbuild ^0.28.1 -> 0.28.1 - js-yaml ^4.2.0 -> 4.2.0 - qs ^6.15.2 -> 6.15.2 Drop the redundant `vite` override (vite is a direct devDependency at ^7.3.5 that already governs the version; an exact override conflicted with it - npm EOVERRIDE). Resolved versions and lockfile are unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
justinmcbride
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dependencies.