fix: derive paths-only branch from feature directory#3060
Open
luohui1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3026 by deriving the paths-only
BRANCHvalue from the resolved feature directory basename when no explicitSPECIFY_FEATUREis available.This keeps
check-prerequisites --paths-only/-PathsOnlyuseful for feature-context invocations that rely on.specify/feature.jsoninstead of an active feature branch environment variable.Split out from #3053 after maintainer feedback to keep each bug fix in its own PR.
Testing
uv run specify --helpuv sync && uv run pytestAdditional validation run locally:
uv run --extra test pytest tests/test_check_prerequisites_paths_only.py -q- 4 passed, 5 skippeduvx ruff check tests/test_check_prerequisites_paths_only.py- passedgit diff --check- passedManual test results
Agent: Codex (GPT-5) | OS/Shell: Windows 11 / PowerShell 7.5.4
.specify/scripts/powershell/check-prerequisites.ps1 -Json -PathsOnlyBRANCHfallback from feature directory basename.AI Disclosure
This PR was implemented by Codex (GPT-5) acting as an AI coding agent on behalf of @luohui1. The agent read the repository contribution/security/code-of-conduct docs and issue templates, inspected the relevant code paths, implemented the changes, ran the validation listed above, and prepared this PR description.