fix: log rollback errors instead of silently swallowing them - #3926
Open
Quratulain-bilal wants to merge 1 commit into
Open
fix: log rollback errors instead of silently swallowing them#3926Quratulain-bilal wants to merge 1 commit into
Quratulain-bilal wants to merge 1 commit into
Conversation
_rollback() caught and discarded all exceptions during component removal. If a rollback step fails, the user has no indication the rollback was incomplete. Add debug logging so failures are visible.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds debug diagnostics for failed best-effort bundle rollbacks.
Changes:
- Imports Python logging.
- Logs exceptions raised while removing rollback components.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/bundler/services/installer.py |
Adds rollback failure logging. |
Review details
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
258
to
+259
| except Exception: # noqa: BLE001 - best-effort rollback | ||
| logger.debug("rollback failed for %s: %s", component, exc_info=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_rollback()caught and discarded all exceptions during component removal. If a rollback step fails, the user has no indication the rollback was incomplete.Fix
Add debug logging so failures are visible.