Repository navigation
Fix local bundle installation for uppercase .ZIP artifacts - #5106
Merged
Merged
Conversation
mnriem
added
the
triage-can-wait
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped fix preserves archive validation and includes appropriate positive and negative regression coverage.
No open issues 🎉
What changed in this PR
Fixes #5090 by making local bundle ZIP recognition case-insensitive, matching remote artifact handling while preserving existing validation.
Changes:
- Normalizes the local artifact suffix before comparing it with
.zip. - Adds CLI regression tests for lowercase and uppercase ZIP installation and rejection of an uppercase ZIP without a manifest.
Validation relies on the PR’s reported before-and-after results; tests were not rerun during this review.
| File | Description |
|---|---|
tests/specify_cli/bundles/test_command_install.py |
Tests case-insensitive installation and missing-manifest rejection. |
src/specify_cli/bundles/sources.py |
Makes local ZIP suffix recognition case-insensitive. |
Review effort: Max
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5090. Local bundle installation now checks ZIP extensions without regard to case, matching remote artifact handling. CLI regression tests cover lowercase and uppercase ZIP installation and rejection of an uppercase ZIP without a manifest.
Testing
Before the source fix, the lowercase case passed and both uppercase cases failed. After the fix, all 73 tests in
test_command_install.pyandtest_sources.pypassed.ruff@0.15.0 check src tests,specify --help, andgit diff --checkpassed.AI Disclosure
AI disclosure: Codex (GPT-6, default reasoning effort) autonomously authored the code and tests and ran the checks above. Human review has not yet occurred.