Repository navigation
fix(bundles): honor bundle integration during init - #5111
Open
chelsealong wants to merge 1 commit into
Open
chelsealong wants to merge 1 commit into
chelsealong wants to merge 1 commit into
Conversation
mnriem
added
the
triage-must-have
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused delegation reuses existing validation and integration selection, with reported regression evidence and no blocking findings.
1 open issue
What changed in this PR
Fixes #5089 by routing fresh-project specify bundle init <bundle> through the existing installation flow, honoring the bundle’s declared integration before initialization.
Changes:
- Reuse installation validation and integration selection before creating the project.
- Add regressions for declared integration selection and incompatible-bundle rejection without leaving
.specifybehind.
Validation relies on the reported before-and-after results; tests were not rerun here.
| File | Description |
|---|---|
tests/specify_cli/bundles/test_command_init.py |
Adds success and rejection regression tests; formats existing tests. |
src/specify_cli/bundles/command_init.py |
Delegates fresh-project initialization with a bundle to the existing install path. |
Review effort: Max
Comment on lines
+49
to
+50
| assert result.exit_code == 1, result.output | ||
| assert not (project / ".specify").exists() |
Collaborator
|
Please address Copilot feedback |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5089. For a fresh project,
bundle init <bundle>now uses the existing install path, which validates the manifest and selects its declared integration before initializing.Testing
Both new regression tests failed before the source fix: one reproduced the Copilot/Claude clash; the other found
.specifyleft behind after an incompatible bundle. Both pass with the fix..venv/bin/python -m pytest tests/specify_cli/bundles -q— 927 passed.venv/bin/specify --help— passedruff checkandruff format --checkon both changed files — passedgit diff --check— passedAI Disclosure
AI disclosure: Codex (GPT-6, autonomous, default reasoning settings) generated the code and tests and ran the checks listed above.