ci: run installer checks in qlean - #38
Conversation
Signed-off-by: Luxian <lux1an@qq.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d2ec81bd9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| use tempfile::tempdir; | ||
|
|
||
| const VERSION: &str = "v0.0.0-qlean"; | ||
| const TARGET: &str = "x86_64-unknown-linux-gnu"; |
There was a problem hiding this comment.
When the documented command is run on an aarch64 Linux host, cargo build produces native aarch64 binaries, but this fixture always publishes them under the x86_64-unknown-linux-gnu asset name. The installer selects its asset from the VM architecture, so an ARM VM requests an asset that was never created, while an x86_64 VM downloads binaries it cannot execute. Gate this test on target_arch = "x86_64" or explicitly build and stage binaries matching the guest target.
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| for binary in ["scorpio", "antares"] { | ||
| let source = repo_root.join("target/release").join(binary); |
There was a problem hiding this comment.
When CARGO_TARGET_DIR or Cargo configuration redirects build artifacts, the documented release build succeeds outside target/, but this test still reports the binaries missing; if an old default artifact exists, it can instead validate stale code. Resolve Cargo's active target directory or pass the built fixture paths explicitly so the VM always tests the binaries produced by the preceding build.
Useful? React with 👍 / 👎.
Signed-off-by: Luxian <lux1an@qq.com>
Signed-off-by: Luxian <lux1an@qq.com>
|
Addressed the automated review feedback in dc5cfc0: the Qlean fixture test is now gated to Linux x86_64, and it resolves Cargo's active arget_directory via cargo metadata before staging release binaries, so custom CARGO_TARGET_DIR/Cargo target-dir configurations are honored. The one-command installer validation instructions are documented above and in README.md. Local WSL rerun is currently blocked by the environment's unavailable crates.io network/proxy; the previous WSL validation and GitHub Actions run remain recorded in this PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc5cfc0544
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| run_checked( | ||
| vm, | ||
| &format!( | ||
| "bash {root}/script/test_installer_systemd.sh {VERSION} http://127.0.0.1:18080 /tmp/scorpiofs-qlean-systemd" |
There was a problem hiding this comment.
In the Qlean workflow, guest commands run as root, as demonstrated by the preceding direct apt-get invocation, but this call neither switches to an unprivileged user nor supplies SUDO_USER. Consequently test_installer_systemd.sh assigns service_user=root and skips its service_user != root permission branch, while all remaining ownership checks use root as the service account; the isolated job can therefore pass without exercising the non-root permission behavior it is intended to validate.
Useful? React with 👍 / 👎.
Signed-off-by: Luxian <lux1an@qq.com>
Signed-off-by: Luxian <lux1an@qq.com>
|
Also addressed the latest automated review in 99a952: the Qlean guest keeps root for VM/system operations but invokes est_installer_systemd.sh with SUDO_USER=nobody, so the non-root service-user, ownership, and permission branches are exercised. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f99a952027
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| run_checked( | ||
| vm, | ||
| &format!( | ||
| "python3 -m http.server 18080 --bind 127.0.0.1 --directory {root}/release >/tmp/scorpiofs-qlean-http.log 2>&1 & server_pid=$!; trap 'kill $server_pid 2>/dev/null || true' EXIT; curl --fail --retry 20 --retry-delay 1 http://127.0.0.1:18080/{VERSION}/scorpiofs-{VERSION}-{TARGET}.tar.gz.sha256 >/dev/null; SUDO_USER=nobody bash {root}/script/test_installer_systemd.sh {VERSION} http://127.0.0.1:18080 /tmp/scorpiofs-qlean-systemd" |
There was a problem hiding this comment.
On a loaded VM, curl can start before the background Python server has bound port 18080, causing this entire command and CI test to fail immediately with exit code 7. The checked curl 8.5.0 --help all distinguishes ordinary --retry from “--retry-connrefused Retry on connection refused (use with --retry),” so add that option or use an explicit readiness loop like the one in .github/workflows/build.yml.
Useful? React with 👍 / 👎.
Signed-off-by: Luxian <lux1an@qq.com>
|
Follow-up in |
Signed-off-by: Luxian <lux1an@qq.com>
|
Final fixture fix in |
Signed-off-by: Luxian <lux1an@qq.com>
|
Mega server URL example for the interactive installer: curl -fsSL https://raw.githubusercontent.com/gitmono-dev/scorpiofs/main/install.sh | sudo bashWhen prompted, enter: For non-interactive use: curl -fsSL https://raw.githubusercontent.com/gitmono-dev/scorpiofs/main/install.sh | sudo bash -s -- --non-interactive --overwrite-config --base-url https://git.rk8s.xuanwu.openatom.cn --lfs-url https://git.rk8s.xuanwu.openatom.cn/lfs |
Signed-off-by: Luxian <lux1an@qq.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47e494cdf1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| required-features = ["qlean-ci"] | ||
|
|
||
| [target.'cfg(target_os = "linux")'.dev-dependencies] | ||
| qlean = "0.3.1" |
There was a problem hiding this comment.
On Linux, a normal cargo test builds every dev-dependency, including qlean and its large transitive dependency graph, even when qlean-ci is disabled; required-features only excludes the integration-test target. This makes the supposedly opt-in VM test impose its compilation time and toolchain/platform requirements on the default test suite. Declare Qlean as an optional dependency and activate it from qlean-ci (for example, qlean-ci = ["dep:qlean"]) so ordinary test runs remain unchanged.
Useful? React with 👍 / 👎.
Signed-off-by: Luxian <lux1an@qq.com>
Signed-off-by: Luxian <lux1an@qq.com>
Signed-off-by: Luxian <lux1an@qq.com>
|
Qlean FUSE verification completed on fc910fd. The Debian guest installs fuse3, kmod, and util-linux, then loads its own fuse kernel module. The test starts the release scorpio serve daemon and waits for the real mount. findmnt reports fuse/fuse.*, stat succeeds on the mountpoint, and cleanup verifies that the mount is detached. Qlean isolated CI passed: https://github.com/gitmono-dev/scorpiofs/actions/runs/32646734369/job/97212028855. Installer usage is documented in the PR body and README. Interactive install: curl -fsSL https://raw.githubusercontent.com/gitmono-dev/scorpiofs/main/install.sh | sudo bash. The installer prompts for the base and LFS URLs; for the Mega server use https://git.rk8s.xuanwu.openatom.cn and https://git.rk8s.xuanwu.openatom.cn/lfs. |
2 participants
Summary
qlean-ciintegration test usingqlean = 0.3.1.The existing fast fmt, clippy, build, and host-side installer checks remain unchanged. The qlean dependency is Linux-only and the VM test is ignored unless explicitly selected.
One-command usage
On a Linux host configured for Qlean:
cargo build --release --locked --bin scorpio --bin antares QLEAN_QEMU_TIMEOUT_SECS=1200 \ cargo test --locked --features qlean-ci --test qlean_installer \ -- --ignored --nocaptureThe same command runs in
.github/workflows/qlean.ymlafter the runner installs QEMU/libvirt and configures/dev/vhost-vsockandqemu-bridge-helper.Verification
cargo fmt --all -- --checkbash script/test_installer.shpassed.--all-targets --all-features -- -D warnings./var/run/libvirt/libvirt-sock); GitHub Actions provisions that prerequisite.