Improve and unify commit author rendering

[silverwind]

1. Add e-mail tooltip over non-existing usernames, only for logged-in users.
2. Use a shared template to render commit author.

[lafriks]

I don't think showing email in the UI is a good idea, maybe only for authorized users

[silverwind]

It was already shown previously as a tooltip on the avatar in the commit view, but was not consistent.

[silverwind]

And yes, I agree it should be hidden for anonymous users, but imho thats a separate topic and we need to validate all places where we pass these addresses to the frontend.

[silverwind]

I think I could actually try to fix this at least in these 3 places, make a subtemplate for "avatar and username" and do the logged in check there, wip until then.

[lunny]

Since the repository is public, it can be accessed freely. Anyone can clone it and obtain the email information locally anyway.

[silverwind]

I guess it has a small benefit against scrape bots.

[lafriks]

Yes, GitHub also does not show emails in git for the very same reason most probably

[silverwind]

This proves harder than I thought because these templates are such a mess, there is .Author, .Commit.Author, .User and I don't know the difference or why there are three variables for the same thing.

[silverwind]

Shared template added but there is a unresolved issue on latest commit page and commit view:

Render failed, failed to render template: repo/home, error: template error: builtin(static):repo/commit_author:25:26 : executing "repo/commit_author" at <.Author.FullName>: can't evaluate field FullName in type interface {}

if .Author.FullName crashes and I don't know how to avoid it. Maybe the template code needs a IsEmptyInterface or something?

[silverwind]

Fixed above by not passing these invalid .Author on the two affected pages. I think this is ready now.

The E-Mail adress is also no longer rendered into HTML for signed-out users.

[wxiaoguang]

I don't think you should pass so many different structs.

Commit is not really used. What you need is a "git user" or "gitea user".

[silverwind]

Commit is used for .Commit.Author vs .Author. Maybe it can be unified, not sure. The three pages all pass different context variables.

[wxiaoguang]

[silverwind]

I wonder if *User will also be compatible with .Author.

[wxiaoguang]

I wonder if *User will also be compatible with .Author.

No. More complicated.

• Change how identities are shown in commit page #24087 (comment)

[wxiaoguang]

There are full of "if-else" blocks.

I don't think such "shared template" can be right. It is very fragile and only causes maintainability problems.

[silverwind]

I don't have a full picture what the 3 variants of data being passed into here are. Deeper analysis will be needed to determine if any of this can be reduced. All your remaining comments are about this same topic. If you have a better picture of the data passed in, feel free to change it yourself.

[wxiaoguang]

Sorry, I don't have a full picture at the moment either. The details I know were written in #24087 (comment) (commit is not really related).

I think I don't have time or motivation to do it at the moment.

If you'd like to use the "shared templates", I think you need to make it clear and maintainable, but not leave the problem to the future maintainers ....