Skip to content

Conversation

@trim21
Copy link
Contributor

@trim21 trim21 commented Jan 25, 2026

the TestGitNode_sshWithDir failed on windows because it use windows path seprator on windows. we should use path.Join to always force a path seprator.

--- FAIL: TestGitNode_sshWithDir (0.00s)
    node_git_test.go:46:
                Error Trace:    C:/Users/Trim21/proj/task/taskfile/node_git_test.go:46
                Error:          Not equal:
                                expected: "ssh://[email protected]/foo/bar.git//directory/common.yml?ref=main"
                                actual  : "ssh://[email protected]/foo/bar.git//directory\\common.yml?ref=main"

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -ssh://[email protected]/foo/bar.git//directory/common.yml?ref=main
                                +ssh://[email protected]/foo/bar.git//directory\common.yml?ref=main
                Test:           TestGitNode_sshWithDir
--- FAIL: TestGitNode_httpsWithDir (0.00s)
    node_git_test.go:74:
                Error Trace:    C:/Users/Trim21/proj/task/taskfile/node_git_test.go:74
                Error:          Not equal:
                                expected: "https://github.com/foo/bar.git//directory/common.yml?ref=main"
                                actual  : "https://github.com/foo/bar.git//directory\\common.yml?ref=main"

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -1 +1 @@
                                -https://github.com/foo/bar.git//directory/common.yml?ref=main
                                +https://github.com/foo/bar.git//directory\common.yml?ref=main
                Test:           TestGitNode_httpsWithDir
FAIL

@trim21 trim21 force-pushed the fix/git-url-on-windows branch from d1961a9 to d51613a Compare January 25, 2026 10:44
@vmaerten vmaerten self-requested a review January 31, 2026 17:48
@vmaerten
Copy link
Member

Thanks!

@vmaerten vmaerten merged commit cf54be3 into go-task:main Jan 31, 2026
14 checks passed
@trim21 trim21 deleted the fix/git-url-on-windows branch January 31, 2026 17:49
vmaerten added a commit that referenced this pull request Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants