fix(git): check cache before context timeout in getOrCloneRepo #2669
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fetching remote git taskfiles, the timeout context is shared across the entire operation including user prompt time. This caused timeouts when processing includes after the user accepted the trust prompt, even when the repository was already cloned. By checking the cache before verifying the context, we allow cache hits to succeed regardless of timeout state, since no network access is needed for cached repositories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Check git repo cache before verifying context timeout in
getOrCloneRepo. This prevents timeout errors when reading includes from the same repo after user spends time on trust prompt, since cached repos don't need network access.fixes #2668
Test plan
rm -rf /tmp/task-git-repos