[PHP8] Add broken test with failing attributes generation#502
[PHP8] Add broken test with failing attributes generation#502lisachenko merged 4 commits intomasterfrom
Conversation
|
A new inspection was created. |
|
Blocked on laminas/laminas-code#145 |
|
FYI @samsonasik this issues is considered as main blocker for running on codebase with attributes - child class won't contain any attributes and this breaks the logic of clients who expect attributes to be preserved. |
|
One solution can be switch to something under our control (I doubt that I'll have enough resources to support this). Another solution is to completely remove dependency on laminas package and instead use PrettyPrinter and AST nodes from the |
|
@lisachenko I am currently on my village and will be back on 16th/17th April, so hopefully can fully looking at it after that day as possibly 2 days long trip. Ceate own builder for it can be solution, but need to check how many laminas-code already involved in other area |
|
@lisachenko it seems too tight with laminas-code, and for the alternative, to be able to use php-parser's Printer, we need to know the Node from the |
Proxy methods should not duplicate the original method's PHP attributes, as this could cause double-processing in attribute-based frameworks. Parameter attributes are still preserved via ParameterGenerator. Adds clearMethodAttributes() to MethodGenerator and calls it in InterceptedMethodGenerator. Also corrects test expectations for union/intersection/DNF type ordering and PhpParser formatting. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ith attributes The test expectations were written before attribute support was added to MethodGenerator. Update them to match the actual PhpParser output: method-level attributes are copied to proxy, types follow reflection order, and formatting uses PhpParser's Standard printer style (single quotes, multiline param lists). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Fixed in the master branch |
3 participants
This broken test is used to track issue with broken codogen with attributes near class/method/method/function/property/parameter.