fix(environments): accept gddy's nested environments.toml shape#59
Merged
Conversation
gddy's already-distributed environments.toml nests entries under a top-level [environments.<name>] table, but Environments::file_defs() only parsed the flat [<name>] shape, so those files would silently fail to resolve any environment once gddy adopts this engine's Environments type instead of its own hand-rolled resolution. DEVEX-929 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
qcai-godaddy
approved these changes
Jul 21, 2026
jpage-godaddy
pushed a commit
that referenced
this pull request
Jul 22, 2026
🤖 I have created a release *beep* *boop* --- ## [0.4.8](cli-engine-v0.4.7...cli-engine-v0.4.8) (2026-07-21) ### Bug Fixes * **environments:** accept gddy's nested environments.toml shape ([#59](#59)) ([e9209b4](e9209b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
environments.tomlnests entries under a top-level[environments.<name>]table (mirroring gddy's own hand-rolledEnvironmentsFile { environments: BTreeMap<..> }), butEnvironments::file_defs()only parsed the flat[<name>]shape.[<name>]shape stays the documented/canonical one; the nested[environments.<name>]shape is accepted as an undocumented compatibility shim so already-shipped files parse without edits. When a name appears in both, the nested entry's fields win.cli-engine's sharedEnvironmentstype instead of its own hand-rolledrust/src/environments/mod.rs).Test plan
cargo fmt --all --checkcargo clippy --all-targets -- -D warningsRUSTDOCFLAGS='-D warnings' cargo doc --no-depscargo test --all-targets(all suites pass, incl. newnested_environments_table_shape_parses_like_flat_shapeandnested_environments_table_wins_over_flat_entry_for_same_name)cargo test --doccargo rustdoc --lib -- -W missing-docs(zero warnings)🤖 Generated with Claude Code