remove required GDP appId - #1467
pbennett1-godaddy wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 162bdd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wcole1-godaddy
left a comment
wcole1-godaddy
left a comment
There was a problem hiding this comment.
Please address the unnecessary Collect SDK load on checkouts that have no GoDaddy payment methods before merging. Keeping application IDs optional makes sense, but the loader should still be gated on whether Collect is needed. The extra download and JavaScript execution add avoidable network and main-thread work to checkout.
| isPoyntLoaded || | ||
| !applicationId?.trim() || | ||
| !collectCDN || | ||
| !businessId |
There was a problem hiding this comment.
[P2] Gate Collect loading on a configured GoDaddy payment method
PaymentForm calls this hook unconditionally, and sessions using other processors can still have a businessId. Removing the application ID guard therefore makes Stripe-only and offline-only checkouts download and execute Collect even when godaddyPaymentsConfig is omitted. I reproduced the loader behavior against the base and this commit: neither checkout inserted the script before this change; both insert it afterward. This adds unnecessary network and JavaScript work on the checkout path.
Please gate loading on a configured GoDaddy payment method while keeping appId optional, and add regression coverage showing that non-GoDaddy-only sessions do not insert the script and GoDaddy sessions without an app ID still do.
wcole1-godaddy
left a comment
wcole1-godaddy
left a comment
There was a problem hiding this comment.
Reviewed at 162bdd8. The previously raised Collect SDK-loading concern is addressed: loading is gated on a configured GoDaddy payment method while app IDs remain optional. No actionable findings. Verified all 612 tests, typecheck, and build pass. Live card tokenization and wallet flows were not exercised; payment tests use SDK mocks.
2 participants
Summary
GoDaddy payment providers and credit card forms were blocked from loading without
godaddyPaymentsConfig.appId, although the Collect runtime only requiresbusinessId.Remove app ID requirements from SDK loading, provider wrapping, payment method availability, and card, ACH, and wallet initialization. Preserve configured app IDs and session overrides.
Changeset
Patch changeset for
@godaddy/react.Test Plan
pnpm --filter @godaddy/react test— all 596 tests passed.pnpm --filter @godaddy/react typecheck— passed.pnpm --filter @godaddy/react build— passed.