CMake - emscripten hack#122
Merged
Merged
Conversation
Add a commented out line for the emscripten hack to indicate what to do when compiling for the platform. resolves godotengine#99
Ivorforce
approved these changes
May 28, 2026
Collaborator
|
@enetheru Can this be merged as-is? |
Contributor
Author
Yes please. The hack is inelegant, but its the best I can come up with. |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a commented out line for the emscripten hack to indicate what to do when compiling for the platform.
Resolves #99
Because the project command has not been specified yet we don't have knowledge of the toolchain, so I've left this commented out. The only way I can imagine is to guard it with a variable, but I think that can be left upto the user of the template.