Use a different method to avoid thread_local on MacOS#1992
Open
dsnopek wants to merge 1 commit into
Open
Conversation
This was referenced May 29, 2026
dsnopek
changed the title
thread_local on MacOSthread_local on MacOS
Collaborator
Author
|
I just tested this with hot-reload on MacOS, and it worked! Taking out of DRAFT |
Contributor
|
Note that hot-reloading might again break if the user uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS,
thread_localstorage keeps the library from being unloaded, which breaks hot-reload.So, we've got some messy code that avoids
thread_local, but we broke it at some point (per #1990)This PR takes an alternative solution to the problem, which should be more efficient, and is definitely less messy.
Marking as DRAFT for now, because I still need to actually test it with hot-reload on macOS :-)Fixes #1990