Clarify SurfaceTool example with index #11529
Open
+17
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| .. code-tab:: csharp | ||
|
|
||
| # Suppose we have a quad defined by 6 vertices as follows |
Member
There was a problem hiding this comment.
Suggested change
| # Suppose we have a quad defined by 6 vertices as follows | |
| // Suppose we have a quad defined by 6 vertices as follows. |
| st.AddVertex(Vector3(1, -1, 0)); | ||
| st.AddVertex(Vector3(-1, -1, 0)); | ||
|
|
||
| # We can make the quad more efficient by using an index array and only utilizing 4 vertices: |
Member
There was a problem hiding this comment.
Suggested change
| # We can make the quad more efficient by using an index array and only utilizing 4 vertices: | |
| // We can make the quad more efficient by using an index array and only utilizing 4 vertices: |
Comment on lines
+148
to
+154
| st.AddVertex(Vector3(-1, 1, 0)); | ||
| st.AddVertex(Vector3(1, 1, 0)); | ||
| st.AddVertex(Vector3(-1, -1, 0)); | ||
|
|
||
| st.AddVertex(Vector3(1, 1, 0)); | ||
| st.AddVertex(Vector3(1, -1, 0)); | ||
| st.AddVertex(Vector3(-1, -1, 0)); |
Member
There was a problem hiding this comment.
Suggested change
| st.AddVertex(Vector3(-1, 1, 0)); | |
| st.AddVertex(Vector3(1, 1, 0)); | |
| st.AddVertex(Vector3(-1, -1, 0)); | |
| st.AddVertex(Vector3(1, 1, 0)); | |
| st.AddVertex(Vector3(1, -1, 0)); | |
| st.AddVertex(Vector3(-1, -1, 0)); | |
| st.AddVertex(new Vector3(-1, 1, 0)); | |
| st.AddVertex(new Vector3(1, 1, 0)); | |
| st.AddVertex(new Vector3(-1, -1, 0)); | |
| st.AddVertex(new Vector3(1, 1, 0)); | |
| st.AddVertex(new Vector3(1, -1, 0)); | |
| st.AddVertex(new Vector3(-1, -1, 0)); |
| st.AddIndex(2); | ||
|
|
||
| // Alternatively: | ||
| // Alternatively we can use `st.Index()` which will create the quad for us and remove the duplicate vertices |
Member
There was a problem hiding this comment.
Suggested change
| // Alternatively we can use `st.Index()` which will create the quad for us and remove the duplicate vertices | |
| // Alternatively we can use `st.Index()` which will create the quad for us and remove the duplicate vertices. |
AThousandShips
added
enhancement
area:manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example looks like an accidental copy paste without adapting the code. I fixed that and made the C# version more consistent.