-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update OpenXR Settings page for 4.6 #11546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
skyace65
wants to merge
1
commit into
godotengine:master
Choose a base branch
from
skyace65:XRSettings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -236,6 +236,18 @@ Debug Message Types | |||||
|
|
||||||
| This allows you to choose which debug messages are logged. | ||||||
|
|
||||||
| Frame Synthesis | ||||||
| ~~~~~~~~~~~~~~~ | ||||||
|
|
||||||
| When enabled, provided it's supported by the XR runtime, lower resolution motion | ||||||
| vector and depth buffers are rendered and provided to the XR runtime. The XR | ||||||
| runtime can now inject reprojection frames and compensate for lower framerates. | ||||||
|
|
||||||
| It currently has the following limitations: | ||||||
|
|
||||||
| - Does NOT work in the Forward+ renderer. | ||||||
| - Only works with stereo rendering. | ||||||
|
|
||||||
| Hand Tracking | ||||||
| ~~~~~~~~~~~~~ | ||||||
|
|
||||||
|
|
@@ -278,6 +290,13 @@ the user is holding a controller. | |||||
| If only a hand interaction profile is supplied any runtime should use hand | ||||||
| interaction even if a controller is being held. | ||||||
|
|
||||||
| Spatial Entity | ||||||
| ~~~~~~~~~~~~~~ | ||||||
|
|
||||||
| This extension and its settings are used to obtain and interacting with | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| information about the user's real world environment. You can find more detailed | ||||||
| information on how it works on the :ref:`spatial entities page <doc_openxr_spatial_entities>`. | ||||||
|
|
||||||
| Eye Gaze Interaction | ||||||
| ~~~~~~~~~~~~~~~~~~~~ | ||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How it's usually called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how it's named on the settings page, I'd rather keep them consistent.

Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's inconsistent with other places, the documentation uses "spatial entities", the settings also says "render model" but the entry here and the associated page says "render models", it's weird to me that the section "Spatial Entity" links to the page "spatial entities", also the OpenXR extension name is "spatial entities" not "spatial entity"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BastiaanOlij is the actual name of the extension the plural version or the singluar version? Because the Kronos website blog uses plural, but then the spec sheet uses singular (here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard one, because we can make arguments for both which is why in this case we see both, even in OpenXRs official documentation.
When we look at a given extension, it's generally named singular. So XR_EXT_spatial_entity, XR_EXT_render_model, XR_EXT_dpad_binding, etc. even though each manages a multitude of objects or items.
However when we look at spatial entities it isn't just the one extension that defines what a single spatial entity looks like. It's a collection of extensions that further detail out how to access different types of spatial entities.
As a system, plural makes more sense imho.