Pass consistent viewport and screen sizes to fix point size emulation. #114194
+59
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point size emulation relies on the viewport size and screen pixel size parameters in the scene UBO. In many effects, these values are set to (1, 1), causing point primitives to cover the entire framebuffer. This PR updates all uses of
_setup_environmentto correctly pass these values in every effect.For the viewport size, this change also passes the actual viewport dimensions instead of the screen size so that point size emulation matches Vulkan. This should make no difference in the main rendering pass, since the viewports there cover the entire framebuffer anyway, and the values were already incorrect for other effects.
Normally, this issue would not be so urgent, but it caused a severe problem in my system. When point primitives are rendered into shadow maps via ubershaders, each point primitive covers the entire shadow map due to the incorrect viewport size values. With thousands of points, the manual culling via
discardin the ubershader creates such a large performance hit that either the FPS drops dramatically, or the driver crashes system-wide due to TDR timeout.