[3.x] Fix editor potentially having multiple instances of the same subresource #114209
+17
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a nasty bug I've been having.
The issue can be reproduced as follows:
You'll see that C now contains a copy of the subresource in A.
The editor loads scenes ignoring the cache, but subresources must still use it, because otherwise loading a higher-level scene will cause new instances of its subresources to be created, while deeply derived scenes will keep pointing to the ones before the load of the top scene.
This PR adds separate cache control for subresources and leverages it in the code where the editor loads a scene.
I've tested and will keep testing, but of course this is slippery ground, so let's be careful. 😀
This PR is proudly donated by Pedrocorp.