[3.x] Use approximate test when comparing properties, thoroughly #114210
+70
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
force-pushed
the
avoid_redundant_values_3.x
branch
from
950e9a5 to
cfdf290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the need for this when I realized derived scenes of one containing an
AnimationPlayerwere getting the blend times array duplicated on save.Something like this:
blend_times = [ "cast", "stopped_caster", 0.3, "dodge", "stopped", 0.3, "dodge", "walk", 0.3, [...]Due to the
0.3being processed differently for some reason in different places, the numeric imprecission would end up causing a comparison between something like0.300001and2.999999.It may be good to hunt down the exact cause for the difference. However, since we are already applying loose comparison for cases like these, I've just extended the approximate comparison framework to work exhaustively.
It would be great to forward-port this to 4.x, but the codebase differs too much and it would require separate study.
This PR is proudly donated by Pedrocorp.