"Discontiguous()" method for CellUnion
#244
Open
+414
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benguild
commented
Dec 14, 2025
Comment on lines
+296
to
+299
| // Discontiguous splits this CellUnion into its discontiguous (non-touching) | ||
| // components. Each returned CellUnion represents a connected region where cells | ||
| // share edges. The input CellUnion should be normalized. Results are sorted by | ||
| // the first CellID in each component for deterministic output. |
Author
There was a problem hiding this comment.
@jmr This is pretty useful and to me it seems like it could be a solid addition. I may try drafting a port to C++ as well, but wanted to ask your thoughts if you had a moment to check it out before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find this useful occasionally, but open to thoughts including about whether it belongs in the library.