EdgeQuery.initCovering: Use a single iterator #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmr
changed the title
EdgeQuery
Collaborator
|
Is it faster? It looks more complicated. |
benguild
force-pushed
the
closestEdgeQueryTODO
branch
from
9f19ca5 to
c8565f7
Compare
Author
Honestly, probably not that much. It's just avoiding the iterator cloning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes #247, but that should probably be merged first while this is reviewed.
Documented previously as the TODO in the code in both Go and C++. This aims to resolve it. If this is not sufficient, please let me know and I'll take a look. I took a shot at the C++ as well (in a draft PR) to match: google/s2geometry#494