feat(test): add timeout support for agents test command#13
Open
ivanleomk wants to merge 5 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a timeout configuration and CLI option for agent testing, allowing users to override the default server timeout. The timeout is parsed, validated, and forwarded as an x-server-timeout header in API stream requests and curl outputs. Feedback suggests tightening the Zod schema validation for timeout to ensure it is a positive integer, and implementing stricter CLI argument validation to prevent partial parsing of invalid timeout strings.
ivanleomk
force-pushed
the
feat/add-timeout-support
branch
4 times, most recently
from
aa4e707 to
a2f3b47
Compare
ivanleomk
force-pushed
the
feat/add-timeout-support
branch
from
a2f3b47 to
d512cf8
Compare
Contributor
|
Can you resolve the conflict? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for a new
timeoutparameter (either via CLI flag--timeoutor in the agent's YAML config) to override thex-server-timeoutheader when executing local tests.