Remove beta warning and obsolete flag conversion for Cloud Run jobs #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloud Run jobs support was added in v2.4.0 with a beta warning. The `--update-secrets` flag is now supported for `gcloud run jobs deploy`, so the flag conversion logic is no longer needed. Fixes google-github-actions#593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #593
Summary
--update-secretsto--set-secretsflag conversion logicBackground
Cloud Run jobs support was added in v2.4.0 (April 2024) with a beta warning. The
--update-secretsflag is now supported forgcloud run jobs deploy, so the flag conversion logic and associated warning are no longer needed.Changes
src/main.ts: Removed beta warning (lines 171-174) and flag conversion logic (lines 192-201)dist/main/index.js: Rebuilt