Skip to content

Conversation

@tylere
Copy link
Contributor

@tylere tylere commented Mar 1, 2025

Simplifies how the desired pixel grid information is specified when opening of datasets.
Previously, crs, scale, projection and geometry were available as parameters.
With this change crs, crs_transform, and shape_2d are used to specify the grid.
See #217 for the rational for this change.

Other changes:

  • Adds pixi package manager configuration files (useful for developers who use pixi)
  • Limits Python to 3.12 (to avoid version conflicts among dependencies)
  • Updates the README code examples

Note that this PR does not update code in the examples/ folder.

@tylere tylere requested review from jdbcode and naschmitz March 1, 2025 00:50
@tylere tylere mentioned this pull request Mar 1, 2025
@jakenotjay
Copy link

jakenotjay commented Sep 24, 2025

Hi @jdbcode and @tylere do you think this will get merged anytime soon? I'm implementing a connector between XEE and icechunk that is covering a lot of ground that would be covered by the changes here. In the discussion where this was first proposed, the idea of mirroring similar parameters such as the odc geobox would be super helpful, as I'm building my models around the geobox too and I'm finding it non-trivial to perfectly align the grid that I have client side and the grid that XEE provides using the geometry parameters.

If there are final review changes required around the affine package etc. I'm happy to help on that front too.

@jdbcode
Copy link
Member

jdbcode commented Sep 24, 2025

I'm going to try to make progress on the unresolved comments over the next week and a half. I'll give an update later next week.

@jdbcode
Copy link
Member

jdbcode commented Sep 30, 2025

@tylere and @naschmitz, the outstanding comments have been addressed (see the last batch of commits). All of the unit and integration tests are passing and the readme has been updated to reflect changes (also expanded).

I'm hoping that you two can take a quick look before the end of the week and then we merge it. Since it is not merging into main, I suggest we continue any additional work that might need to be done when it is in the google:simplify_pixel_grid_params branch.

@jdbcode jdbcode requested a review from naschmitz September 30, 2025 00:01
Copy link
Collaborator

@naschmitz naschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! Thank you!

@naschmitz naschmitz merged commit a9ab143 into google:simplify_pixel_grid_params Oct 6, 2025
1 check passed
@tylere
Copy link
Contributor Author

tylere commented Oct 6, 2025

Thank you @jdbcode and @naschmitz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants