-
Notifications
You must be signed in to change notification settings - Fork 42
Simplify proj params #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify proj params #225
Conversation
PiperOrigin-RevId: 712905652
PiperOrigin-RevId: 712996660
Ensure shape_2d is a tuple
|
Hi @jdbcode and @tylere do you think this will get merged anytime soon? I'm implementing a connector between XEE and icechunk that is covering a lot of ground that would be covered by the changes here. In the discussion where this was first proposed, the idea of mirroring similar parameters such as the odc geobox would be super helpful, as I'm building my models around the geobox too and I'm finding it non-trivial to perfectly align the grid that I have client side and the grid that XEE provides using the geometry parameters. If there are final review changes required around the affine package etc. I'm happy to help on that front too. |
|
I'm going to try to make progress on the unresolved comments over the next week and a half. I'll give an update later next week. |
|
@tylere and @naschmitz, the outstanding comments have been addressed (see the last batch of commits). All of the unit and integration tests are passing and the readme has been updated to reflect changes (also expanded). I'm hoping that you two can take a quick look before the end of the week and then we merge it. Since it is not merging into main, I suggest we continue any additional work that might need to be done when it is in the google:simplify_pixel_grid_params branch. |
naschmitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing! Thank you!
|
Thank you @jdbcode and @naschmitz ! |
Simplifies how the desired pixel grid information is specified when opening of datasets.
Previously,
crs,scale,projectionandgeometrywere available as parameters.With this change
crs,crs_transform, andshape_2dare used to specify the grid.See #217 for the rational for this change.
Other changes:
Note that this PR does not update code in the
examples/folder.