fix(flows): resume long-running tools after matching responses#5072
Open
zeel2104 wants to merge 1 commit intogoogle:mainfrom
Open
fix(flows): resume long-running tools after matching responses#5072zeel2104 wants to merge 1 commit intogoogle:mainfrom
zeel2104 wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
LongRunningFunctionToolresume could fail in resumable flows when streaming was enabled. There were two compounding issues:functionResponsehad already resolved the long-running tool call.Solution:
This change fixes both sides of the resume path:
functionResponseIDs in the current invocation branch before deciding to stop execution.Testing Plan
I verified the change with targeted unit tests covering both parts of the fix:
resumable invocation logic now continues when a long-running tool call has a matching functionResponse
streaming finalization preserves function call IDs across partial and final events
Commands run
python -m pytest tests\unittests\agents\test_invocation_context.py tests\unittests\flows\llm_flows\test_base_llm_flow.py -q --basetemp=.pytest_tmp
python -m pytest tests\unittests\agents\test_invocation_context.py -q -k "has_unresolved_long_running_tool_calls" --basetemp=.pytest_tmp
python -m pytest tests\unittests\flows\llm_flows\test_base_llm_flow.py -q -k "preserves_function_call_ids" --basetemp=.pytest_tmp
Unit Tests:
Passed locally: