fix(executors): add best-effort POSIX timeout for Python skill scripts, enforce timeout_seconds in ContainerCodeExecutor#5083
Draft
caohy1988 wants to merge 1 commit intogoogle:mainfrom
Conversation
…rCodeExecutor - Add best-effort SIGALRM-based timeout for Python skill scripts on POSIX (guarded by hasattr so Windows is unaffected) - Replace ContainerCodeExecutor.exec_run() with thread-based exec_create/ exec_start to honor timeout_seconds, with best-effort kill on timeout - Expand UnsafeLocalCodeExecutor docstring with security guidance Closes google#5079 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5079 — timeout enforcement gaps in code executors.
RunSkillScriptTool'sscript_timeoutnow applies to Python scripts viasignal.SIGALRMon POSIX. Guarded byhasattr(signal, 'SIGALRM')so Windows is unaffected (no regression). This is cooperative/best-effort — scripts that catchTimeoutErrorcan continue.execute_code()now usesexec_create/exec_startin a daemon thread withthread.join(timeout=...)to honortimeout_seconds. On timeout, best-effortkill -9of the exec PID inside the container. Whentimeout_seconds=None, waits indefinitely (backward compatible).Limitations
Test plan
test_execute_script_python_includes_timeout— verifies generated wrapper containssignal.alarmandhasattrguardtest_python_script_timeout_fires_with_real_executor— POSIX integration test proving SIGALRM kills a sleeping script (skipped on Windows)TestContainerTimeout::test_timeout_returns_error— exec_start that blocks is killed after timeoutTestContainerTimeout::test_no_timeout_waits_indefinitely— None timeout = backward compatTestContainerTimeout::test_normal_execution_within_timeout— fast command within timeoutTestContainerTimeout::test_exec_start_exception_propagated— Docker API errors re-raisedtest_skill_toolset.py+code_executors/)🤖 Generated with Claude Code