Add perfetto tracing to host tooling#2502
Open
jmacnak wants to merge 1 commit into
Open
Conversation
jmacnak
force-pushed
the
perfetto
branch
7 times, most recently
from
e958a29 to
8330f27
Compare
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
jmacnak
force-pushed
the
perfetto
branch
4 times, most recently
from
19542bf to
6e9eaf0
Compare
jmacnak
force-pushed
the
perfetto
branch
5 times, most recently
from
1d90f66 to
1727b13
Compare
Member
Author
|
This needs a couple upstream changes to Perfetto but generally ready for a first look. |
Databean
reviewed
May 19, 2026
Databean
left a comment
Databean
left a comment
Member
There was a problem hiding this comment.
Not finished reviewing, but I'll leave the comments I have so far.
LalitMaganti
pushed a commit
to google/perfetto
that referenced
this pull request
May 19, 2026
Bug: b/378560215 This would be useful for google/android-cuttlefish#2502 where we could eliminate most of https://github.com/google/android-cuttlefish/pull/2502/changes#diff-d28a094890e585d0e9bec027b845e31c3c15ebd9c2262dd814dd6e7537ab2af8 when using the c library via `dlopen()` and we do not want to directly depend on the library itself.
jmacnak
force-pushed
the
perfetto
branch
5 times, most recently
from
7be473c to
7e57fd5
Compare
Databean
reviewed
May 20, 2026
Databean
left a comment
Databean
left a comment
Member
There was a problem hiding this comment.
Sorry, still not finished: I haven't fully reviewed TracingState, but have looked at everything else.
Databean
reviewed
May 21, 2026
jmacnak
force-pushed
the
perfetto
branch
3 times, most recently
from
c7146ac to
fc5b377
Compare
jmacnak
added a commit
to jmacnak/android-cuttlefish
that referenced
this pull request
May 28, 2026
google#2502 was incorrect. The previous behavior was to prefer `--gpu_mode=gfxstream` over `--gpu_mode=guest_swiftshader` prior to the Jolt changes. Bug: b/513229182
Databean
reviewed
May 28, 2026
| return *sCached; | ||
| } | ||
|
|
||
| uint64_t GetThreadId() { return gettid(); } |
Member
There was a problem hiding this comment.
Sorry to flip from my earlier comment on this, but I saw that the internal libc may not include gettid: b/456374254
Example cvd create trace: https://ui.perfetto.dev/#!/?s=b1b38a42593f61ee34c230f344e62f8c883ec747 Example cvd fetch trace: https://ui.perfetto.dev/#!/?s=cd5028170d015f9dd026228c7fd7dd81027b680e Perfetto uses a shared memory buffer between producer processes and the traced consumer daemon. `fork()` is problematic for this as the parent and child processes would end up clobbering each other when the shared memory buffer is inherited by the child. To prevent this, we introduce a "perfetto forwarder" (see TracingSession) that runs in the top level `cvd` process and that forwards trace events from child processes. Bug: b/378560215
Databean
approved these changes
Jun 12, 2026
Databean
left a comment
Databean
left a comment
Member
There was a problem hiding this comment.
Sorry, lost track of this change.
| sigset_t set; | ||
| sigemptyset(&set); | ||
| sigaddset(&set, SIGTERM); | ||
| CF_EXPECT_EQ(pthread_sigmask(SIG_BLOCK, &set, nullptr), 0, |
Member
There was a problem hiding this comment.
The example for pthread_sigmask includes the comment
/* Block SIGQUIT and SIGUSR1; other threads created by main()
will inherit a copy of the signal mask. */Should the pthread_sigmask call be made before TracingServer::StartBlocking launches additional threads, so the threads have a chance to inherit the altered mask?
| shutting_down_ = true; | ||
| } | ||
|
|
||
| socket_->Shutdown(SHUT_RDWR); |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example cvd create trace:
https://ui.perfetto.dev/#!/?s=b1b38a42593f61ee34c230f344e62f8c883ec747
Example cvd fetch trace:
https://ui.perfetto.dev/#!/?s=cd5028170d015f9dd026228c7fd7dd81027b680e