Clarify proxy port vs. non-proxy port + show the non-proxy port to the user#2690
Open
dxapd wants to merge 1 commit into
Open
Clarify proxy port vs. non-proxy port + show the non-proxy port to the user#2690dxapd wants to merge 1 commit into
dxapd wants to merge 1 commit into
Conversation
jemoreira
reviewed
Jun 10, 2026
Comment on lines
+194
to
+197
| // The port for the signaling (operator) server. | ||
| void set_sig_server_port(int port); | ||
| int sig_server_port() const; | ||
|
|
Member
There was a problem hiding this comment.
This is a constant, it doesn't need to be in the config.
Collaborator
Author
There was a problem hiding this comment.
got it, I'll remove this config declaration. if I want to avoid hardcoding "1443" in the string in streamer.cpp, where should i declare the constant? i don't believe i saw this constant defined anywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seemed as though the naming was conflating the proxy port with the actual operator port, so I renamed the proxy port to suit what it actually was. Also changed streamer.cpp to show the non-proxy port to the user instead of the proxy port.