Support podcvd load#2706
Open
0405ysj wants to merge 5 commits into
Open
Conversation
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for adding security option on podman container creation rather than enabling
vhost_user_vsockwas not to break suspend/resume feature on podcvd worked withoutvhost_user_vsock, andpodcvd loaddoesn't support configuration field to enablevhost_user_vsockwithin canonical configuration.Not only supported
podcvd load, but also refactored logic which is about mounting proper paths by reading flag values. This is required in advance of dealing with--config_fileflag ofpodcvd createwhich is highly-related topodcvd load, but I couldn't complete it in this PR. This should be followed in the next one.Context: b/491256959