Better cvd help stop message#2713
Open
jemoreira wants to merge 1 commit into
Open
Conversation
Updated to document stopping a subset of instances in the group. More details on how the stop operation works. Document selector flags too. Adds the wait_for_launcher_seconds flag alias to make the time unit more obvious.
Databean
approved these changes
Jun 13, 2026
| description.emplace_back( | ||
| HelpParagraph::Raw("Usage:\n cvd [selectors] stop [args]")); | ||
| description.emplace_back( | ||
| "Stop a subset of instances from a group. A single instance, severall or " |
Comment on lines
+119
to
+120
| "The stop operation attemps to graciously stop the instances by sending " | ||
| "an ACPI shutdown. If the shutdown doesn't complete within the " |
Member
There was a problem hiding this comment.
There is no "ACPI shutdown", was this hallucinated? The distinction is whether processes are SIGKILLed or not. The "nice" shutdown still uses crosvm stop, which immediately stops all KVM threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to document stopping a subset of instances in the group. More details on how the stop operation works.
Document selector flags too.
Adds the wait_for_launcher_seconds flag alias to make the time unit more obvious.
Bug: b/523416547