container/(docker|podman): rewrite obtaining IP-address #3768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The top-level IPAddress field is deprecated in the API, so instead, the IP-address should be obtained from the container's primary network. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Contributor
Author
|
Opening separate, because I don't know if PodMan returns the Networks the same as Docker. This information is a bit ambiguous overall, as the original design assumption a container would have a single IP-address, but the IP-address of the container can differ per network. I think this rewrite is closest to the old behavior. |
Collaborator
|
@robmry @haircommander please let me know when this is ready |
|
LGTM - but I don't know about Podman either. |
Contributor
|
lemme dig around for someone who's more active in podman to review |
Contributor
Author
|
Thanks! Yes, I wasn't sure who was best to ping for this, and I wasn't sure how close the API implementation of podman was on this front 🤗 |
2 tasks
Collaborator
|
let's merge and iterate. folks can file follow up PRs |
dims
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top-level IPAddress field is deprecated in the API, so instead, the IP-address should be obtained from the container's primary network.