-
Notifications
You must be signed in to change notification settings - Fork 620
Set fuzzer author as reporter for bugs from external fuzzers #5312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jr2bg
wants to merge
3
commits into
master
Choose a base branch
from
feature/report-by-fuzzer-owner
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -320,6 +320,7 @@ def file_issue(testcase, | |
| logs.info(f'Filing new issue for testcase: {testcase.key.id()}.') | ||
|
|
||
| policy = issue_tracker_policy.get(issue_tracker.project) | ||
| fuzzer = None | ||
| is_crash = not utils.sub_string_exists_in(NON_CRASH_TYPES, | ||
| testcase.crash_type) | ||
| properties = policy.get_new_issue_properties( | ||
|
|
@@ -482,7 +483,10 @@ def file_issue(testcase, | |
| testcase.one_time_crasher_flag and policy.unreproducible_component): | ||
| issue.components.add(policy.unreproducible_component) | ||
|
|
||
| issue.reporter = user_email | ||
| if fuzzer and fuzzer.external_contribution and fuzzer.primary_owner: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks good, but I'm wondering whether the Before we enable this we should verify. |
||
| issue.reporter = fuzzer.primary_owner | ||
| else: | ||
| issue.reporter = user_email | ||
|
|
||
| if issue_tracker.project in ('chromium', 'chromium-testing'): | ||
| logs.info( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """Script to migrate fuzzer owners.""" | ||
|
|
||
| import argparse | ||
| import os | ||
| import sys | ||
|
|
||
| # Ensure the local project root is in the path | ||
| sys.path.append(os.path.join(os.path.dirname(__file__), '../src')) | ||
| sys.path.append(os.path.join(os.path.dirname(__file__), '../src/appengine')) | ||
|
|
||
| from google.cloud import ndb | ||
|
|
||
| from clusterfuzz._internal.datastore import data_types | ||
| from libs import helpers | ||
|
|
||
|
|
||
| def migrate(dry_run=True, default_owner='default-owner@example.com'): | ||
| """Migrates fuzzer owners.""" | ||
| query = data_types.Fuzzer.query( | ||
| ndb.OR( | ||
| data_types.Fuzzer.primary_owner == None, # pylint: disable=singleton-comparison | ||
| data_types.Fuzzer.primary_owner == '')) | ||
|
|
||
| count = 0 | ||
| for fuzzer in query.fetch(): | ||
| print(f"Processing fuzzer: {fuzzer.name}") | ||
| if not dry_run: | ||
| fuzzer.primary_owner = default_owner | ||
| fuzzer.put() | ||
| helpers.log( | ||
| f"Backfilled primary_owner for {fuzzer.name} to {default_owner}", | ||
| helpers.MODIFY_OPERATION) | ||
| count += 1 | ||
|
|
||
| mode = "DRY RUN" if dry_run else "LIVE" | ||
| print(f"{mode}: Processed {count} fuzzers.") | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| parser = argparse.ArgumentParser( | ||
| description='Backfill primary_owner for Fuzzers.') | ||
| parser.add_argument( | ||
| '--live', action='store_true', help='Perform live updates.') | ||
| parser.add_argument( | ||
| '--owner', | ||
| default='default-owner@example.com', | ||
| help='Default owner email.') | ||
| args = parser.parse_args() | ||
|
|
||
| migrate(dry_run=not args.live, default_owner=args.owner) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be a DataStore look up?