Skip to content

Always clean up TLS auto-dictionary. #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 11, 2026
+6 −8
Merged

Always clean up TLS auto-dictionary. #2090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions centipede/sancov_state.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,12 @@ void CleanUpSancovTls() {
if (sancov_state->flags.callstack_level != 0) {
tls.call_stack.Reset(sancov_state->flags.callstack_level);
}
if (sancov_state->flags.use_auto_dictionary) {
tls.cmp_trace2.Clear();
tls.cmp_trace4.Clear();
tls.cmp_trace8.Clear();
tls.cmp_traceN.Clear();
}
RunnerCheck(tls.sancov_lowest_sp != nullptr,
"sancov_lowest_sp is null for a live thread");
*tls.sancov_lowest_sp = tls.lowest_sp = tls.top_frame_sp;
Expand All @@ -325,14 +331,6 @@ void CleanUpSancovTls() {

void PrepareSancov(bool full_clear) {
if (full_clear) {
sancov_state->ForEachTls([](ThreadLocalSancovState& tls) {
if (sancov_state->flags.use_auto_dictionary) {
tls.cmp_trace2.Clear();
tls.cmp_trace4.Clear();
tls.cmp_trace8.Clear();
tls.cmp_traceN.Clear();
}
});
sancov_state->pc_counter_set.ForEachNonZeroByte(
[](size_t idx, uint8_t value) {}, 0,
sancov_state->actual_pc_counter_set_size_aligned);
Expand Down
Loading