mm: enforce RLIMIT_DATA considering total data segment size (heap + data + bss) - #14082
Open
Ar1es-XD wants to merge 1 commit into
Open
mm: enforce RLIMIT_DATA considering total data segment size (heap + data + bss)#14082Ar1es-XD wants to merge 1 commit into
Ar1es-XD wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…ata + bss) Currently, MemoryManager.Brk only enforces RLIMIT_DATA for the heap because it only checks `uint64(addr - mm.brk.Start)` against the limit, ignoring the size of other private writable segments (like .data and .bss) which are mapped by the loader and tracked by `mm.dataAS`. Fix this by checking the total size of private writable data segments (heap + data + bss + private writable mappings) against RLIMIT_DATA. Fixes google#156. Assisted-by: Gemini CLI
Ar1es-XD
force-pushed
the
fix-rlimit-data
branch
from
August 12, 2026 09:58
0f6d4f6 to
8253971
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, MemoryManager.Brk only enforces RLIMIT_DATA for the heap because it only checks
uint64(addr - mm.brk.Start)against the limit, ignoring the size of other private writable segments (like .data and .bss) which are mapped by the loader and tracked bymm.dataAS.Fix this by checking the total size of private writable data segments (heap + data + bss + private writable mappings) against RLIMIT_DATA.
Fixes #156.
Assisted-by: Gemini CLI