gofer: Fix inode cache collisions on file type mismatches - #14100
Open
copybara-service[bot] wants to merge 1 commit into
Open
gofer: Fix inode cache collisions on file type mismatches#14100copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
The Gofer client caches inodes by (device_id, inode_number). Collisions can occur when different files share a host inode number and map to the same device ID in Sentry (e.g., across different bind mounts resolved by the same Gofer instance). This CL modifies the inode cache lookup to evict stale cached inodes on file type mismatches, and updates the destruction path to prevent cache corruption when evicted-but-still-alive inodes are torn down. PiperOrigin-RevId: 963768742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gofer: Fix inode cache collisions on file type mismatches
The Gofer client caches inodes by (device_id, inode_number).
Collisions can occur when different files share a host inode number
and map to the same device ID in Sentry (e.g., across different bind
mounts resolved by the same Gofer instance). This CL modifies the
inode cache lookup to evict stale cached inodes on file type
mismatches, and updates the destruction path to prevent cache
corruption when evicted-but-still-alive inodes are torn down.