fix(set_cover): initialize thread_pool_ and remove stale ThreePhase declaration (fixes #5341) - #5375
Open
jdymitarai wants to merge 2 commits into
Open
Conversation
…eclaration (fixes google#5341)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5341.
This PR addresses two issues in
ortools/set_cover/set_cover_lagrangian:Remove stale
ThreePhasedeclaration:set_cover_lagrangian.hdeclaredvoid ThreePhase(Cost upper_bound);with no corresponding definition inortools/set_cover(the three-phase algorithm was migrated toset_cover_cft.ccasRunThreePhase).&SetCoverLagrangian::ThreePhaseleads to link-time or runtime symbol import errors (undefined symbol: _ZN19operations_research18SetCoverLagrangian10ThreePhaseEd). The stale declaration is removed.Initialize
thread_pool_to prevent SIGSEGV inComputeLowerBound:thread_pool_was initialized tonullptrin constructors unlessUseNumThreads()was explicitly called prior toComputeLowerBound(). Uninitializedthread_pool_dereferences resulted in a segmentation fault when parallel methods scheduled tasks.thread_pool_withthis->params().num_threadsin constructors, and added a defensive guard inComputeLowerBound()ensuringthread_pool_is initialized if null.Testing
SetCoverTest.LagrangianComputeLowerBoundDefaultThreadPoolinortools/set_cover/set_cover_test.ccverifying thatComputeLowerBound()executes successfully on a freshSetCoverLagrangianwithout requiringUseNumThreads().ortools/set_cover/BUILD.bazelto include:set_cover_lagrangianinset_cover_testdependencies.