Split LUT node identification from transform. - #4667
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_954770753
branch
3 times, most recently
from
July 29, 2026 17:46
f040d5f to
2d7abd5
Compare
Now, the LUT conversion process is split from node identification (i.e. applicability) and transform. This is a conversion to prepare for generalizing the pass for arbitrary nodes. The implementation still only looks at selector nodes; however, it does cast back into the more general `Node` type in preparation for generalization. No additional unit tests were added as behavior is unchanged. PiperOrigin-RevId: 955987844
copybara-service
Bot
force-pushed
the
test_954770753
branch
from
July 29, 2026 19:03
2d7abd5 to
c123cb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split LUT node identification from transform.
Now, the LUT conversion process is split from node identification (i.e. applicability) and transform. This is a conversion to prepare for generalizing the pass for arbitrary nodes. The implementation still only looks at selector nodes; however, it does cast back into the more general
Nodetype in preparation for generalization.No additional unit tests were added as behavior is unchanged.