Skip to content

[anneal][v2] Stabilize Nix omnibus archive builds#3444

Merged
joshlf merged 1 commit into
mainfrom
Gvs2nuhwbbh5phbtjrqaw4uc7odrdp7ce
Jun 7, 2026
Merged

[anneal][v2] Stabilize Nix omnibus archive builds#3444
joshlf merged 1 commit into
mainfrom
Gvs2nuhwbbh5phbtjrqaw4uc7odrdp7ce

Conversation

@joshlf

@joshlf joshlf commented Jun 7, 2026

Copy link
Copy Markdown
Member

Teach the Nix archive builder to construct all supported platform archives from platform-specific upstream artifacts, unpack Mathlib cache archives using a native leantar, and seed vendored Lake path packages from the unpacked cache layout.

Run the archive verification build in Lake's old mtime mode with deterministic source/config mtimes so the prebuilt cache artifacts are replayed instead of invalidated and rebuilt in the Nix sandbox.


Latest Update: v2 — Compare vs v1

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v1 Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gvs2nuhwbbh5phbtjrqaw4uc7odrdp7ce && git checkout -b pr-Gvs2nuhwbbh5phbtjrqaw4uc7odrdp7ce FETCH_HEAD

Checkout

git fetch origin refs/heads/Gvs2nuhwbbh5phbtjrqaw4uc7odrdp7ce && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gvs2nuhwbbh5phbtjrqaw4uc7odrdp7ce && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gvs2nuhwbbh5phbtjrqaw4uc7odrdp7ce

Stacked PRs enabled by GHerrit.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@codecov-commenter

codecov-commenter commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (88393fc) to head (d551e1d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3444   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6093     6093           
=======================================
  Hits         5597     5597           
  Misses        496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf force-pushed the Gvs2nuhwbbh5phbtjrqaw4uc7odrdp7ce branch from ac3faf7 to 1eec343 Compare June 7, 2026 00:20
@joshlf joshlf force-pushed the Gqbvdpe5hujures6czytfxm2bfeoeddlx branch from d95dbca to 11bf7f7 Compare June 7, 2026 00:20

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

Base automatically changed from Gqbvdpe5hujures6czytfxm2bfeoeddlx to main June 7, 2026 01:15
Teach the Nix archive builder to construct all supported platform archives from platform-specific upstream artifacts, unpack Mathlib cache archives using a native leantar, and seed vendored Lake path packages from the unpacked cache layout.

Run the archive verification build in Lake's old mtime mode with deterministic source/config mtimes so the prebuilt cache artifacts are replayed instead of invalidated and rebuilt in the Nix sandbox.

gherrit-pr-id: Gvs2nuhwbbh5phbtjrqaw4uc7odrdp7ce
@joshlf joshlf force-pushed the Gvs2nuhwbbh5phbtjrqaw4uc7odrdp7ce branch from 1eec343 to d551e1d Compare June 7, 2026 01:15
@joshlf joshlf merged commit fcc561c into main Jun 7, 2026
25 checks passed

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf deleted the Gvs2nuhwbbh5phbtjrqaw4uc7odrdp7ce branch June 7, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants