chore: update code to be compatible with protobuf v36 - #16342
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the Protobuf dependency to version 36.0-rc2 across Bazel configurations, Dockerfiles, and workspace files, and casts several Protobuf method calls to (void) to ignore their return values. The reviewer feedback correctly notes that casting any.UnpackTo(&result) to (void) in extract_long_running_result.cc silently swallows unpacking errors, violating the repository's 'Demand Explosive Correctness' principle, and suggests returning an error status if unpacking fails.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16342 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 2246 2246
Lines 212121 212136 +15
=======================================
+ Hits 195707 195729 +22
+ Misses 16414 16407 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b852f97 to
cf100b5
Compare
| #git_override( | ||
| # module_name = "protobuf", | ||
| # commit = "d65ed10e49acbee0e7d14277ab3e0330a0dd2838", | ||
| # remote = "https://github.com/protocolbuffers/protobuf.git", | ||
| #) |
There was a problem hiding this comment.
Done.
Also reverted back to the previous, 35.1, as it's the recommended minimum version.
cf100b5 to
637e308
Compare
dda7a65 to
6357b40
Compare
2 participants
No description provided.