chore(storage): skip ACL system tests for uniform bucket-level access - #9000
Closed
thiyaguk09 wants to merge 3 commits into
Closed
chore(storage): skip ACL system tests for uniform bucket-level access#9000thiyaguk09 wants to merge 3 commits into
thiyaguk09 wants to merge 3 commits into
Conversation
product-auto-label
Bot
added
the
api: storage
thiyaguk09
force-pushed
the
chore/system-test-skip-ubla
branch
from
July 29, 2026 07:52
b662f35 to
a424442
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request skips several ACL-related system tests in handwritten/storage/system-test/storage.ts and adds TODO comments explaining the reasoning. Feedback suggests updating these TODO comments to accurately state that the tests are skipped due to uniform bucket-level access (which disables ACLs) rather than public IAM role restrictions.
thiyaguk09
marked this pull request as ready for review
July 29, 2026 08:13
thiyaguk09
force-pushed
the
chore/system-test-skip-ubla
branch
7 times, most recently
from
August 5, 2026 04:34
2842ea6 to
44cdfb8
Compare
Dhriti07
reviewed
Aug 5, 2026
thiyaguk09
force-pushed
the
chore/system-test-skip-ubla
branch
from
August 5, 2026 06:43
44cdfb8 to
170ea8a
Compare
thiyaguk09
force-pushed
the
chore/system-test-skip-ubla
branch
from
August 5, 2026 09:06
bb7b3a4 to
7ceae7f
Compare
thiyaguk09
marked this pull request as draft
August 5, 2026 11:54
thiyaguk09
force-pushed
the
chore/system-test-skip-ubla
branch
from
August 6, 2026 03:36
7ceae7f to
d896c86
Compare
Contributor
Author
|
ACL tests are now passing, so I am closing this "skip ACL test" PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕