Skip to content

feat(o11y): introduce observability flags needed within the generator - #9052

Open
shivanee-p wants to merge 6 commits into
mainfrom
shivaneep-o11y-flag
Open

feat(o11y): introduce observability flags needed within the generator#9052
shivanee-p wants to merge 6 commits into
mainfrom
shivaneep-o11y-flag

Conversation

@shivanee-p

@shivanee-p shivanee-p commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Adds support for the o11y feature flag to gapic-generator-typescript

  • Added enableTelemetryTracing flag parsing (enable_telemetry_tracing=true)
  • Added enableTelemetryTracing option support to API schema and Naming options
  • Added corresponding unit tests
  • Created unit tests for the generator

@shivanee-p
shivanee-p requested a review from a team as a code owner July 31, 2026 20:38
@github-actions
github-actions Bot requested a review from feywind July 31, 2026 20:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for an enableTelemetryTracing option across the generator, schema, and client interface packages, including adding the option to ClientOptions and introducing an InternalTelemetry interface. Feedback suggests updating the parameter parsing in the generator to support both hyphenated and snake_case parameter names for consistency with other flags, and to only set the property to true when explicitly configured.

Comment thread core/generator/gapic-generator-typescript/typescript/src/generator.ts Outdated
Comment thread core/packages/gax/src/clientInterface.ts
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-flag branch from 1926b69 to 3330e73 Compare August 4, 2026 01:55
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-flag branch from c7259a4 to 4159976 Compare August 4, 2026 03:22
@shivanee-p
shivanee-p requested a review from westarle August 4, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants