feat(firestore-api): implement subpath exports, declare long dependency, and discontinue v1beta1 - #9073
Merged
quirogas merged 5 commits intoAug 4, 2026
Conversation
…obuf reflection serialization (googleapis#8928)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures the firestore-api package to preserve its package.json and adds subpath exports to it, while also moving the 'long' dependency to production dependencies. The reviewer suggests using conditional exports with a 'types' condition in package.json to prevent TypeScript compilation errors under modern module resolution modes.
…v1beta1 generation (googleapis#8928)
quirogas
changed the title
MarkDuckworth
approved these changes
Aug 4, 2026
MarkDuckworth
left a comment
MarkDuckworth
left a comment
Contributor
There was a problem hiding this comment.
Approved, but I'm strongly in favor of removing the exports with wildcards from package.json, unless these are required.
…onfiguration file mappings (googleapis#8928) - Remove wildcard asterisk export entries (./v1/*, ./protos/*, ./build/*) to prevent external reliance on private implementation scripts - Add explicit named subpath export mappings for firestore_client_config.json and protos.json to ensure zero breaking changes across internal wrapper consumers - Verify 100% passing test execution across all client and admin service operations
quirogas
changed the title
quirogas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel architectural update to
@google-cloud/firestore-apisupporting the handwritten Firestore SDK disentanglement (#8928).Summary of Changes
longDependency: Moves"long"fromdevDependenciesto runtime"dependencies". Generated declaration files (protos.d.ts) explicitly importlong. In environments using strict package managers with node_modules isolation (such aspnpm), omittinglongfrom runtime dependencies causes TypeScript compilation to fail witherror TS2307: Cannot find module 'long'(per structural context ingoogleapis/nodejs-firestore#2322)../v1,./client_v1,./admin_v1,./protos, and configuration files) with the"types"condition placed before"default". This ensures declaration files resolve correctly for consumers using modern TypeScript module resolution ("moduleResolution": "nodenext").v1beta1: Removedv1beta1fromlibrarian.yamland regenerated the library vialibrarianto stop generating beta client code.Internal: b/531788771