feat: update API sources and regenerate - #9104
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several Google Cloud client libraries with new API features, such as the AccessPolicies service in IAM, ExaAiSearch tool in AI Platform, and SearchMessages in Google Chat, alongside generating new Compute Engine clients (Hosts and ReliabilityRisks). A review comment correctly points out that the manual modification of '.repo-metadata.json' in the Compute Engine package should be avoided; instead, the pretty name change should be configured via 'name_pretty_override' in 'librarian.yaml' to ensure it is preserved during future code regenerations.
| "library_type": "GAPIC_AUTO", | ||
| "name": "compute", | ||
| "name_pretty": "Google Compute Engine", | ||
| "name_pretty": "Compute Engine", |
There was a problem hiding this comment.
According to the repository rules, you should not manually edit the generated '.repo-metadata.json' file to change the pretty name. Instead, please configure 'name_pretty_override' in 'librarian.yaml' to avoid naming conflicts and ensure the change is preserved during future regenerations.
References
- To override the metadata name and pretty name for a library to avoid naming conflicts, configure 'metadata_name_override' and 'name_pretty_override' in 'librarian.yaml' instead of manually editing the generated '.repo-metadata.json' file.
|
we should merge #9109 first |
feywind
left a comment
feywind
left a comment
There was a problem hiding this comment.
I know my comment is not about your stuff, but the protos themselves... just wanted to make sure!
| // Required. Information gathered about the device being used when the ad | ||
| // event happened. | ||
| DeviceInfo device_info = 8 [(google.api.field_behavior) = OPTIONAL]; | ||
| DeviceInfo device_info = 8 [(google.api.field_behavior) = REQUIRED]; |
There was a problem hiding this comment.
Is that going to cause a breaking change?
There was a problem hiding this comment.
this does look breaking to me. Technically I don't think ads has the same restrictions as cloud for breaking changes, but it doesn't mean we shouldn't specify it.
Let me bring it up with the Librarian team next week.
2 participants
No description provided.