Skip to content

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Dec 12, 2025

When the underlying streaming RPC has an unrecoverable error we need to preserve the error and return it on future read_range() requests.

Fixes #4052

When the underlying streaming RPC has an unrecoverable error we need to
preserve the error and return it on future `read_range()` requests.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.19%. Comparing base (4348b9c) to head (71e6362).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/src/storage/bidi/worker.rs 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4064      +/-   ##
==========================================
+ Coverage   95.16%   95.19%   +0.03%     
==========================================
  Files         175      175              
  Lines        6722     6729       +7     
==========================================
+ Hits         6397     6406       +9     
+ Misses        325      323       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review December 13, 2025 14:36
@coryan coryan requested a review from a team as a code owner December 13, 2025 14:36
@coryan coryan merged commit 1180b56 into googleapis:main Dec 15, 2025
29 checks passed
@coryan coryan deleted the impl-storage-preserve-unrecoverable-errors branch December 15, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve error that terminates a worker

2 participants