feat: adding Otel for MPU #3387
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Dhriti07
force-pushed
the
mpu-otel-new
branch
from
ed6998a to
df66376
Compare
BenWhitehead
requested changes
Nov 20, 2025
Collaborator
BenWhitehead
left a comment
BenWhitehead
left a comment
There was a problem hiding this comment.
The lint failures can be fixed by running
JAVA_HOME=$JAVA_17_HOME mvn com.spotify.fmt:fmt-maven-plugin:format
This branch will need to be rebased on main to pickup the new method for listing uploads. git fetch --all && git rebase -i origin/main
Other than that, this is looking like I'd expect it to.
| .put("gcp.client.version", StorageOptions.getDefaultInstance().getLibraryVersion()) | ||
| .put("gcp.client.repo", "googleapis/java-storage") | ||
| .put("gcp.client.artifact", "com.google.cloud:google-cloud-storage") | ||
| .put("rpc.system", transport.toString().toLowerCase(Locale.ROOT)) |
Collaborator
There was a problem hiding this comment.
the value here should be "XML" since it's using the xml api, not the json api.
added 2 commits
December 3, 2025 02:36
BenWhitehead
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.