Repository navigation
fix: Correct the URL scheme and port used on the psc_endpoint branch in Sandboxes.send_command and Sandboxes.generate_browser_ws_headers. The branch added in cl/981254234 built https://{psc_endpoint} and defaulted to port 443, but PSC endpoints for VPC-SC sandboxes route directly to the sandbox router pod, which serves plain HTTP on the caller-supplied port (default 8080) and does not terminate TLS on 443. As a result every VPC-SC data-plane call through the SDK hung on ConnectTimeout at HTTPSConnectionPool(host='<psc-ip>', port=443). The endpoint is now built as http://{psc_endpoint}:{port} for send_command and ws://{psc_endpoint}:{port} for generate_browser_ws_headers, so the URL matches what the router serves. Non-VPC-SC callers (load_balancer_hostname / load_balancer_ip branches) are unaffected. - #7236
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…h in `Sandboxes.send_command` and `Sandboxes.generate_browser_ws_headers`. The branch added in cl/981254234 built `https://{psc_endpoint}` and defaulted to port 443, but PSC endpoints for VPC-SC sandboxes route directly to the sandbox router pod, which serves plain HTTP on the caller-supplied port (default 8080) and does not terminate TLS on 443. As a result every VPC-SC data-plane call through the SDK hung on `ConnectTimeout` at `HTTPSConnectionPool(host='<psc-ip>', port=443)`. The endpoint is now built as `http://{psc_endpoint}:{port}` for `send_command` and `ws://{psc_endpoint}:{port}` for `generate_browser_ws_headers`, so the URL matches what the router serves. Non-VPC-SC callers (`load_balancer_hostname` / `load_balancer_ip` branches) are unaffected.
PiperOrigin-RevId: 983303249
product-auto-label
Bot
added
the
api: vertex-ai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Correct the URL scheme and port used on the
psc_endpointbranch inSandboxes.send_commandandSandboxes.generate_browser_ws_headers. The branch added in cl/981254234 builthttps://{psc_endpoint}and defaulted to port 443, but PSC endpoints for VPC-SC sandboxes route directly to the sandbox router pod, which serves plain HTTP on the caller-supplied port (default 8080) and does not terminate TLS on 443. As a result every VPC-SC data-plane call through the SDK hung onConnectTimeoutatHTTPSConnectionPool(host='<psc-ip>', port=443). The endpoint is now built ashttp://{psc_endpoint}:{port}forsend_commandandws://{psc_endpoint}:{port}forgenerate_browser_ws_headers, so the URL matches what the router serves. Non-VPC-SC callers (load_balancer_hostname/load_balancer_ipbranches) are unaffected.